Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(django): Fix psycopg3 reconnect error #3111

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

szokeasaurusrex
Copy link
Member

Fixes GH-3061

@szokeasaurusrex
Copy link
Member Author

Marking as draft since I am unsure how to properly test this change

@szokeasaurusrex
Copy link
Member Author

Note to self: run tests with SENTRY_PYTHON_TEST_POSTGRES_NAME=postgres tox -e py3.12-django-latest -- tests/integrations/django/test_basic.py::test_connection_reconnect_does_not_error, with Docker Postgres container started

@szokeasaurusrex szokeasaurusrex changed the title fix(django): Fix psycopg3 fix(django): Fix psycopg3 reconnect error Jun 6, 2024
@szokeasaurusrex
Copy link
Member Author

Testing this change is not super-straightforward; I am still struggling to figure out how to make my test work.

So that the lack of a test does not block the release of this bug fix, we will implement the test later. I have opened Issue #3139 to add a test, and have put my in-progress work in a draft PR linked on that issue

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review June 6, 2024 15:12
@szokeasaurusrex szokeasaurusrex merged commit 6a9d152 into master Jun 11, 2024
113 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/fix-psycopg branch June 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with _set_db_data when using psycopg3
3 participants