Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test for Psycopg3 fix #3138

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jun 6, 2024

Draft PR containing a test for #3111. In order to implement this change, we first would need to modify our test suite to allow running tests against both psycopg2 and 3. For testing purposes, this change modifies our test suite to only run against psycopg3; we would undo this change before merging

The main challenge preventing this change from working is an error occurring during test teardown. The test itself passes; the teardown error is the only problem. The test also tests the feature as intended: if we undo the change from #3111, the test fails.

Adding transaction=True to the Pytest-Django decorator eliminates the teardown error allowing the test to pass; however, if we undo #3111, the test still passes, indicating that running with transaction=True does not properly test the functionality we wish to verify.

Resolves #3139

@szokeasaurusrex szokeasaurusrex changed the title Szokeasaurusrex/test psycopg fix WIP: Test for Psycopg3 fix Jun 6, 2024
Base automatically changed from szokeasaurusrex/fix-psycopg to master June 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants