Skip to content

Commit

Permalink
fix(options): Remove "tunnel" from SDK options (#3787)
Browse files Browse the repository at this point in the history
* feat(ReactNativeClientOptions): Remove "tunnel" option

Remove the "tunnel" option from the ReactNativeClientOptions type due to lack of support in React Native.

* fix build

* add changelog

* fix link

* fix lint

---------

Co-authored-by: AliReza <38973917+AliReza99@users.noreply.github.com>
  • Loading branch information
krystofwoldrich and AliReza99 committed May 6, 2024
1 parent 4294805 commit 77fd95a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- Remove `tunnel` from SDK Options ([#3787](https://github.com/getsentry/sentry-react-native/pull/3787))
- Fix Apple non UIKit builds ([#3784](https://github.com/getsentry/sentry-react-native/pull/3784))

### Dependencies
Expand Down
2 changes: 1 addition & 1 deletion src/js/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class ReactNativeClient extends BaseClient<ReactNativeClientOptions> {
const envelope = createUserFeedbackEnvelope(feedback, {
metadata: this._options._metadata,
dsn: this.getDsn(),
tunnel: this._options.tunnel,
tunnel: undefined,
});
this._sendEnvelope(envelope);
}
Expand Down
4 changes: 3 additions & 1 deletion src/js/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ export interface ReactNativeTransportOptions extends BrowserTransportOptions {

export interface ReactNativeOptions extends Options<ReactNativeTransportOptions>, BaseReactNativeOptions {}

export interface ReactNativeClientOptions extends ClientOptions<ReactNativeTransportOptions>, BaseReactNativeOptions {}
export interface ReactNativeClientOptions
extends Omit<ClientOptions<ReactNativeTransportOptions>, 'tunnel'>,
BaseReactNativeOptions {}

export interface ReactNativeWrapperOptions {
/** Props for the root React profiler */
Expand Down

0 comments on commit 77fd95a

Please sign in to comment.