Skip to content

Commit

Permalink
fix: Auto add release and dist to every artifact upload (#3540)
Browse files Browse the repository at this point in the history
  • Loading branch information
krystofwoldrich committed Jan 22, 2024
1 parent 46f3245 commit c365469
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- Sentry CLI 2.25.1 fixes background debug files uploads during Xcode builds ([#3486](https://github.com/getsentry/sentry-react-native/pull/3486))
- Performance Tracing should be disabled by default ([#3533](https://github.com/getsentry/sentry-react-native/pull/3533))
- Use `$NODE_BINARY` to execute Sentry CLI in Xcode scripts ([#3493](https://github.com/getsentry/sentry-react-native/pull/3493))
- Return auto Release and Dist to source maps auto upload ([#3540](https://github.com/getsentry/sentry-react-native/pull/3540))

### Dependencies

Expand Down
2 changes: 1 addition & 1 deletion scripts/sentry-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ LOCAL_NODE_BINARY=${NODE_BINARY:-node}

REACT_NATIVE_XCODE=$1

[[ "$AUTO_RELEASE" != true ]] && [[ -z "$BUNDLE_COMMAND" || "$BUNDLE_COMMAND" != "ram-bundle" ]] && NO_AUTO_RELEASE="--no-auto-release"
[[ "$AUTO_RELEASE" == false ]] && [[ -z "$BUNDLE_COMMAND" || "$BUNDLE_COMMAND" != "ram-bundle" ]] && NO_AUTO_RELEASE="--no-auto-release"
ARGS="$NO_AUTO_RELEASE $SENTRY_CLI_EXTRA_ARGS $SENTRY_CLI_RN_XCODE_EXTRA_ARGS"

REACT_NATIVE_XCODE_WITH_SENTRY="\"$SENTRY_CLI_EXECUTABLE\" react-native xcode $ARGS \"$REACT_NATIVE_XCODE\""
Expand Down
7 changes: 3 additions & 4 deletions sentry.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,9 @@ gradle.projectsEvaluated {
def process = ["node", hasSourceMapDebugIdScript, sourcemapOutput].execute(null, new File("$reactRoot"))
def exitValue = process.waitFor()
project.logger.lifecycle("Check generated source map for Debug ID: ${process.text}")
def notIncludeRelease = "$bundleCommand" == "bundle" && exitValue == 0
def not = notIncludeRelease ? 'not ' : ''
project.logger.lifecycle("Sentry Source Maps upload will ${not}include the release name and dist.")
extraArgs.addAll(notIncludeRelease ? [] : [

project.logger.lifecycle("Sentry Source Maps upload will include the release name and dist.")
extraArgs.addAll([
"--release", releaseName,
"--dist", versionCode
])
Expand Down

0 comments on commit c365469

Please sign in to comment.