-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash information is sent again after every startup #169
Comments
So you are saying reports are sent twice? |
@vincejah I just fixed an issue that could be related to this. |
@HazAT it seems to have fixed the issue, but switching from 0.14.5 to 0.14.13 make native crash reporting not working (captureMessage and captureException are ok though) |
@vincejah |
@HazAT triggering a native crash with 0.14.14 prevents the application from exiting and crash report is still not sent |
I've reverted the changes, I am working on it want to get tests running first. |
I've just released |
@HazAT You will see the codepush is installed but it is not used. Here is my stacktrace:
|
@vincejah This should be resolved. |
@HazAT my code cannot have this error at startup as one of them is a generated crash that is triggered when clicking on a button. I'll test with the latest release. |
@HazAT The problem occurs again when switching from 0.21.2 to 0.29.0. |
@vincejah can you upgrade to |
@HazAT 0.30.0 is not proposed by npm (latest available build on npm is 0.29.0) |
@vincejah please try again |
@HazAT It still occurs on 0.30.0. |
I'm encountering this on our Android app as well--several fixed issues are getting re-reported at startup even across different builds. Would love a fix/workaround for this as it's eating a lot of our events! |
Hi! It seems like we're also affected by this. Unfortunately it makes it really confusing to check if a bug has been fixed or not. This almost renders Sentry useless for us... |
Hey, sorry it was so quiet around this issue. |
Can you guys send me links to your events that got sent twice please? |
Sure! https://sentry.io/drops-t0/drops-react-native/issues/408265228/ << this was an exception we have thrown manually. It has been removed from the codebase at least 3 days ago - around version 3.11 - but it's still showing up in 3.15. We have disabled codepush in order to verify that this is not coming from there. |
@HazAT : I can see there's an open PR for this. any ETA for merging it in? we're going live soon (within 24 hours - although soft launching), and it'd be great to get accurate crash reports, otherwise we don't know where we're standing. |
@itchingpixels So I am having a hard time reproducing this.
and run would love to get feedback |
sure, happy to, will roll this out tonight |
will be releasing this in a few hours. will report back later today if we can still reproduce this issue with the latest build! it'll be actually quite easy to verify, we'll have a result in 24 hours, that I'd be 99% confident in. |
Hi @HazAT: FAILURE: Build failed with an exception.
BUILD FAILED this is when using your branch. Do you have any advice? |
@itchingpixels Damn it, ok npm is not considering |
@itchingpixels
Please do not use this for a prod release. |
You mean we should upload it to somewhere we control it before using it in prod? |
First this yes, |
We've rolled it out to our beta country. will report back later when we have a meaningful amount of data! It'll take longer, since our beta country has a substantially smaller userbase. |
I'm around 90% certain that this has helped. By Monday, we can say with 99.9%. |
Ok, that's good news 👍 |
I can confirm with 99% confidence that this works - none of the already fixed crashes appear with the latest version we've published! |
I've just released version |
Scenario:
A user has a crash with my application. it is successfully reported by Sentry. The crash is fixed on the next application release. On the first application run after the upgrade, the same crash is reported again (while it did not occur again). And worse, the reported software version is the new one. And this occurs at every software upgrade (on both Android and iOS)
I am using:
The text was updated successfully, but these errors were encountered: