Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0-alpha.6 hardcodes Folly version which makes it incompatible if used with a react-native version that uses a different one (e.g. RN0.69) #2557

Closed
5 of 11 tasks
miallo opened this issue Oct 19, 2022 · 1 comment

Comments

@miallo
Copy link
Contributor

miallo commented Oct 19, 2022

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 5.0.0-alpha.6

react-native version: 0.69.6

Are you using Expo?

  • Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

N.a.


I have following issue:

A hardcoded Folly-version will mean that this has to be in sync with the one included by react-native. A similar issue is e.g. here where the solution is just to remove the hardcoded folly_version here

Steps to reproduce:
In a react-native@0.69.6-project trying to run

npm install @sentry/react-native@5.0.0-alpha.6
RCT_NEW_ARCH_ENABLED=1 pod install

Actual result:

It will throw the error:

[!] CocoaPods could not find compatible versions for pod "RCT-Folly":
  In snapshot (Podfile.lock):
    RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)

  In Podfile:
    RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)

    RNScreens (from `../node_modules/react-native-screens`) was resolved to 3.18.2, which depends on
      RCT-Folly

    RNSentry (from `../node_modules/@sentry/react-native`) was resolved to 5.0.0-alpha.6, which depends on
      RCT-Folly (= 2021.07.22.00)

    React-RCTBlob (from `../node_modules/react-native/Libraries/Blob`) was resolved to 0.69.6, which depends on
      RCT-Folly (= 2021.06.28.00-v2)

Expected result:

Sentry should work with different react-native versions.

@marandaneto
Copy link
Contributor

Please use the latest stable version v4 https://github.com/getsentry/sentry-react-native/releases/tag/4.6.1
For the Sentry RN SDK v5, because of the new architecture changes, we're supporting only RN >= 0.70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants