RNSentry.podspec: remove hardcoded Folly version #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Oct 19, 2022
krystofwoldrich
requested changes
Oct 21, 2022
There was a problem hiding this comment.
@miallo Thank you for fixing this.
Could you update the changelog? After that, we can merge this.
## Unreleased
### Fixes
- Remove hardcoded Folly version ([#2558](https://github.com/getsentry/sentry-react-native/pull/2558))
This is done, because that makes it incompatible with react-native versions that hardcode a different version (e.g. 0.69.6)
|
@krystofwoldrich Done :) I hope it is all right :) |
krystofwoldrich
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done, because that makes it incompatible with react-native versions that hardcode a different version
Fixes #2557
馃摙 Type of change
馃摐 Description
Do not hardcode RCT-Folly version
馃挕 Motivation and Context
This makes it compatible with a react-native version that uses a different Folly version. See #2557
馃挌 How did you test it?
Manually patched the file in
node_modules馃摑 Checklist
馃敭 Next steps