Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN 0.49+] requiresMainQueueSetup needed for main queue setup, with constantsToExport #259

Closed
2 tasks
fungilation opened this issue Oct 11, 2017 · 4 comments
Closed
2 tasks
Assignees

Comments

@fungilation
Copy link

fungilation commented Oct 11, 2017

OS:

  • MacOS

Platform:

  • iOS

Console warning:

Module RNSentry requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Same for RNSentryEventEmitter

screenshot 2017-10-10 22 18 15

react-native info:

Environment:
  OS:  macOS Sierra 10.12.6
  Node:  8.6.0
  Yarn:  1.2.0
  npm:  5.3.0
  Watchman:  4.9.0
  Xcode:  Xcode 9.0 Build version 9A235
  Android Studio:  Not Found

Packages: (wanted => installed)
  react: 16.0.0-beta.5 => 16.0.0-beta.5
  react-native: 0.49.3 => 0.49.3

Reference PR for fix

https://github.com/wix/react-native-navigation/pull/1983/files#diff-b8c48202d12fa78c4c377e5a3225c298

@HazAT HazAT self-assigned this Oct 11, 2017
@HazAT
Copy link
Member

HazAT commented Oct 11, 2017

Thanks for reporting this, I will look into it.

@tomaskazatel
Copy link

@HazAT
Copy link
Member

HazAT commented Oct 13, 2017

Hey, I will release an update for this today 👍
Thx for your help.

HazAT added a commit that referenced this issue Oct 13, 2017
HazAT added a commit that referenced this issue Oct 13, 2017
@HazAT
Copy link
Member

HazAT commented Oct 13, 2017

I've just released 0.28.0 which fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants