[Mac Catalyst] Build issues in a React Native project with Sentry

[birdofpreyru]

OS:

• Windows
• MacOS
• Linux

Platform:

• iOS
• Android
• Mac Catalyst

SDK:

• @sentry/react-native (>= 1.0.0)
• react-native-sentry (<= 0.43.2)

SDK version: 5.3.0

react-native version: 0.71.5

Are you using Expo?

• Yes
• No

Are you using sentry.io or on-premise?

• sentry.io (SaaS)
• on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

[Link to issue]

Configuration:
Irrelevant.

---

I have following issue:

I am trying to build an existing (i.e. it builds & works fine for iOS target) React Native project with Sentry for Mac Catalyst. The build results in a few errors in Sentry SDK's Objective-C code, which I believe should be patched as the following:

sentry-react-native/ios/RNSentry.mm

Line 111 in acadc0f

BOOL enableNativeCrashHandling = (BOOL)[mutableOptions valueForKey:@"enableNativeCrashHandling"];

should become

BOOL enableNativeCrashHandling = [mutableOptions valueForKey:@"enableNativeCrashHandling"] != nil;

and here:

sentry-react-native/ios/RNSentry.mm

Line 122 in acadc0f

BOOL enableAutoPerformanceTracing = (BOOL)[mutableOptions valueForKey:@"enableAutoPerformanceTracing"];

should become

BOOL enableAutoPerformanceTracing = [mutableOptions valueForKey:@"enableAutoPerformanceTracing"] != nil;

Otherwise compiler gives me this error in both places:

Cast from pointer to smaller type 'BOOL' (aka 'signed char') loses information

I can create a PR later if these look right for you, or probably you'll be faster just to do these corrections yourself :)

I have submitted PR #2945

Steps to reproduce:

• Step 1
• Step 2

Actual result:

[Actual result]

Expected result:

[Expected result]

[krystofwoldrich]

Hi,
thank you for the issue and PR. There is already an existing PR for this issue.

• fix(apple): Disable enableNativeCrashHandling and enableAutoPerformanceTracing #2936