fix(apple): Disable enableNativeCrashHandling and enableAutoPerformanceTracing

[mwerder]

fix cast to BOOL for sentry init options 'enableNativeCrashHandling' and 'enableAutoPerformanceTracing'

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

Environment:
XCode: 14.2
sentry/react-native: ^5.2.0
platform: MacOS Catalyst & iOS

I integrated sentry into our react-native catalyst app for MacOS.
While building I ran into following errors:

"cast from pointer to smaller type 'bool' (aka 'signed char') loses information"
on following lines inside RNSentry.mm:

ln:111 BOOL enableNativeCrashHandling = (BOOL)[mutableOptions valueForKey:@"enableNativeCrashHandling"];

ln:122BOOL enableAutoPerformanceTracing = (BOOL)[mutableOptions valueForKey:@"enableAutoPerformanceTracing"];

I'm not familiar with objective-c and its types. As the type BOOL behaves differently on 32 and 64-bit machines, I thought that was the problem. But both, iOS and MacOS are 64-bit systems.
So I cannot figure out why it works on iOS but it throws an error on MacOS.

What I found out after testing though, is that with the existing cast, the options enableNativeCrashHandling and enableAutoPerformanceTracing are always true even if I set them to false inside the Sentry.init() options (test cases 5 and 6 below failed with the existing code using the (BOOL) cast).

By debugging I can confirm that following if statement is never entered when setting enableNativeCrashHandling to false:

BOOL enableNativeCrashHandling = (BOOL)[mutableOptions valueForKey:@"enableNativeCrashHandling"];

if (!enableNativeCrashHandling) {

  NSMutableArray *integrations = sentryOptions.integrations.mutableCopy;
  [integrations removeObject:@"SentryCrashIntegration"];
  sentryOptions.integrations = integrations;
}

💡 Motivation and Context

Fixes catalyst build and allows options enableNativeCrashHandling & enableAutoPerformanceTracing to be disabled on iOS

The solution is based on following answer on Stack Overflow

💚 How did you test it?

I ran tests locally while running the app on iOS and macOS. Tested all options using console.logs to verify the options are set correctly.
As mentioned above, using the existing code I always get true. So test case 5 and 6 are failing.
This would mean that it is not possible to disable AutoPerformanceTracing and NativeCrashHandling.
I tried to look into the test cases but honestly, I'm not sure where to add them as the options seems to be mocked.
Would this need an e2e test to verify the iOS code?

#	Sentry.init options	expected Result	actual Result iOS	actual Result MacOS	Pass/Fail
1	enableAutoPerformanceTracing: not set (default)	1	1	1	✅
2	enableNativeCrashHandling: not set (default)	1	1	1	✅
3	enableAutoPerformanceTracing: true	1	1	1	✅
4	enableNativeCrashHandling: true	1	1	1	✅
5	enableAutoPerformanceTracing: false	0	0	0	✅
6	enableNativeCrashHandling: false	0	0	0	✅

closes: #2944

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• All tests passing
• No breaking changes

🔮 Next steps

Maybe add test cases for options.

[krystofwoldrich]

Thank you for the PR,
the changes look good, also thank you for the detailed description, that is awesome.

We have a few tests for the method createOptionsWithDictionary would you be to add few to the changes you made to avoid future regression. (enable/disable enableNativeCrashHandling and check if the the integrations are present or not, enable/disable enableAutoPerformanceTracing and check if the private flags are set correctly)

[mwerder]

Hey @krystofwoldrich thanks for your message.

I added some tests and can confirm that without my changes, enableAutoPerformanceTracing and enableNativeCrashHandling were enabled even if set to false within the options:

With my fix all tests pass:

I had to add following line inside RNSentry.mm to check the state of AutoPerformanceTracing:

sentryOptions.enableAutoPerformanceTracing = enableAutoPerformanceTracing;

[krystofwoldrich]

Looks good. Thank you @mwerder and @birdofpreyru 🚀

[mwerder]

Glad I could contribute. Thanks for your help @krystofwoldrich 🚀