Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sentry-expo client name and version #3021

Closed
krystofwoldrich opened this issue Apr 28, 2023 · 3 comments
Closed

Update sentry-expo client name and version #3021

krystofwoldrich opened this issue Apr 28, 2023 · 3 comments
Assignees
@krystofwoldrich
Labels
Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Apr 28, 2023 •
edited
Loading

Description

Currently, sentry expo uses the client name and version of the underlying SDKs. This is especially good for the SDKs developer to quickly know what client setup created the event.

sentry.javascript.react -> sentry.javascript.react.expo
sentry.javascript.react-native -> sentry.javascript.react-native.expo

For this sentry-react-native would need to expose a config option first.
sentry.java.android -> sentry.java.android.react-native.expo
sentry.cocoa -> sentry.cocoa.react-native.expo

Backlink #2814
Sentry Docs https://develop.sentry.dev/sdk/event-payloads/sdk/
@krystofwoldrich krystofwoldrich changed the title Update sentry-expo client name Update sentry-expo client name and version Apr 28, 2023
@krystofwoldrich krystofwoldrich self-assigned this May 8, 2023
@krystofwoldrich
Copy link
Member Author

Expo PR

@github-actions

This comment was marked as resolved.

Sign in to view
@krystofwoldrich
Copy link
Member Author

Tracked in #3102

@krystofwoldrich krystofwoldrich closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krystofwoldrich krystofwoldrich

Labels
Platform: React-Native
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marandaneto @krystofwoldrich