chore(native): Add `react-native` postfix to native SDKs #2814

krystofwoldrich · 2023-02-08T13:42:14Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Set's RN SDK name and version to the Native SDKs.

💡 Motivation and Context

Hybrid SDKs should set the sentryClientName on Native SDKs during SDK init. team-mobile#48
closes: Set the sentryClientName on Native SDKs during SDK init #2813

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

~~blocked by: HintUtils.isFromHybridSdk and HintUtils.setIsFromHybridSdk should use hints instead sentry-java#2525~~
#skip-changelog

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

github-actions · 2023-02-08T14:50:02Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1258.80 ms	1277.16 ms	18.36 ms
Size	2.92 MiB	3.40 MiB	492.58 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB

Previous results on branch: set-native-sdks-name

Startup times

Revision	Plain	With Sentry	Diff
`0ac162c`+dirty	1249.84 ms	1258.44 ms	8.60 ms

App size

Revision	Plain	With Sentry	Diff
`0ac162c`+dirty	2.92 MiB	3.37 MiB	464.78 KiB

github-actions · 2023-02-08T15:04:02Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	268.84 ms	320.48 ms	51.64 ms
Size	7.15 MiB	8.04 MiB	910.84 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB

Previous results on branch: set-native-sdks-name

Startup times

Revision	Plain	With Sentry	Diff
`0ac162c`+dirty	342.15 ms	392.79 ms	50.64 ms

App size

Revision	Plain	With Sentry	Diff
`0ac162c`+dirty	7.15 MiB	8.08 MiB	959.47 KiB

github-actions · 2023-02-08T15:47:04Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	344.36 ms	349.08 ms	4.72 ms
Size	17.73 MiB	19.75 MiB	2.02 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`d7401ac`+dirty	375.20 ms	383.51 ms	8.31 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d7401ac`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

Previous results on branch: set-native-sdks-name

Startup times

Revision	Plain	With Sentry	Diff
`0ac162c`+dirty	392.39 ms	392.94 ms	0.55 ms

App size

Revision	Plain	With Sentry	Diff
`0ac162c`+dirty	17.73 MiB	20.04 MiB	2.30 MiB

github-actions · 2023-02-08T16:10:06Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1264.06 ms	1280.74 ms	16.68 ms
Size	2.36 MiB	2.82 MiB	462.85 KiB

Baseline results on branch: 5.0.0

Startup times

Revision	Plain	With Sentry	Diff
`d091239`+dirty	1251.49 ms	1276.75 ms	25.26 ms
`d760caf`+dirty	1266.80 ms	1290.92 ms	24.12 ms
`b868b53`+dirty	1274.90 ms	1305.68 ms	30.78 ms

App size

Revision	Plain	With Sentry	Diff
`d091239`+dirty	2.36 MiB	2.74 MiB	384.64 KiB
`d760caf`+dirty	2.36 MiB	2.81 MiB	462.03 KiB
`b868b53`+dirty	2.36 MiB	2.74 MiB	384.64 KiB

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

marandaneto · 2023-02-10T12:09:36Z

We need to check this getsentry/develop#832
Maybe we need to be more explicit about the SDK naming (for the native SDKs).
Maybe we are looking into sentry.java.android.react-native and sentry.cocoa.react-native. if I got it right?

krystofwoldrich · 2023-02-13T09:32:12Z

We need to check this getsentry/develop#832 Maybe we need to be more explicit about the SDK naming (for the native SDKs). Maybe we are looking into sentry.java.android.react-native and sentry.cocoa.react-native. if I got it right?

Yes. I understand the same.

sentry.java.android.react-native with a version of the sentry.java.android
sentry.cocoa.react-native with a version of the sentry.cocoa

CHANGELOG.md

github-actions · 2023-04-04T00:10:43Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

marandaneto · 2023-04-06T15:37:01Z

@krystofwoldrich I believe we can easily fix this since it's possible to do on iOS and Android, right? you can check Flutter.

krystofwoldrich · 2023-04-07T09:41:55Z

@marandaneto Yes.

marandaneto · 2023-04-07T11:49:12Z

@krystofwoldrich dont forget to ping @kahest and the data team about updating the SDK family sheet.

Set RN SDK metadata to the native SDKs

7835fd0

krystofwoldrich requested a review from marandaneto as a code owner February 8, 2023 13:42

marandaneto reviewed Feb 8, 2023

View reviewed changes

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java Outdated Show resolved Hide resolved

krystofwoldrich mentioned this pull request Feb 8, 2023

HintUtils.isFromHybridSdk and HintUtils.setIsFromHybridSdk should use hints instead getsentry/sentry-java#2525

Closed

krystofwoldrich added 2 commits February 8, 2023 16:15

Merge remote-tracking branch 'origin/5.0.0' into set-native-sdks-name

07719fa

Add changelog

3368a42

krystofwoldrich requested a review from marandaneto February 8, 2023 15:21

marandaneto reviewed Feb 10, 2023

View reviewed changes

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java Outdated Show resolved Hide resolved

Base automatically changed from 5.0.0 to main February 21, 2023 12:15

krystofwoldrich marked this pull request as draft February 21, 2023 12:26

marandaneto reviewed Mar 13, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

github-actions bot added the Status: Stale label Apr 4, 2023

marandaneto added Status: Backlog and removed Status: Stale labels Apr 6, 2023

krystofwoldrich and others added 3 commits April 7, 2023 12:27

Merge remote-tracking branch 'origin/main' into set-native-sdks-name

f0a8fd3

Use react-native at the end of native sdks names

120ca26

Merge branch 'main' into set-native-sdks-name

6b33039

krystofwoldrich marked this pull request as ready for review April 7, 2023 11:14

krystofwoldrich requested a review from marandaneto April 7, 2023 11:14

marandaneto approved these changes Apr 7, 2023

View reviewed changes

Merge branch 'main' into set-native-sdks-name

0079071

krystofwoldrich changed the title ~~Set RN SDK metadata to the native SDKs~~ chore(native): Add react-native postfix to native SDKs Apr 11, 2023

krystofwoldrich enabled auto-merge (squash) April 11, 2023 08:37

krystofwoldrich merged commit 850e1e5 into main Apr 11, 2023

krystofwoldrich deleted the set-native-sdks-name branch April 11, 2023 08:40

krystofwoldrich mentioned this pull request Apr 28, 2023

Update sentry-expo client name and version #3021

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(native): Add `react-native` postfix to native SDKs #2814

chore(native): Add `react-native` postfix to native SDKs #2814

krystofwoldrich commented Feb 8, 2023 •

edited

Loading

github-actions bot commented Feb 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: set-native-sdks-name

Startup times

App size

github-actions bot commented Feb 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: set-native-sdks-name

Startup times

App size

github-actions bot commented Feb 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: set-native-sdks-name

Startup times

App size

github-actions bot commented Feb 8, 2023

Baseline results on branch: 5.0.0

Startup times

App size

marandaneto commented Feb 10, 2023

krystofwoldrich commented Feb 13, 2023

github-actions bot commented Apr 4, 2023

marandaneto commented Apr 6, 2023

krystofwoldrich commented Apr 7, 2023

marandaneto commented Apr 7, 2023

chore(native): Add react-native postfix to native SDKs #2814

chore(native): Add react-native postfix to native SDKs #2814

Conversation

krystofwoldrich commented Feb 8, 2023 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Feb 8, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: set-native-sdks-name

Startup times

App size

github-actions bot commented Feb 8, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: set-native-sdks-name

Startup times

App size

github-actions bot commented Feb 8, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: set-native-sdks-name

Startup times

App size

github-actions bot commented Feb 8, 2023

iOS (legacy) Performance metrics 🚀

Baseline results on branch: 5.0.0

Startup times

App size

marandaneto commented Feb 10, 2023

krystofwoldrich commented Feb 13, 2023

github-actions bot commented Apr 4, 2023

marandaneto commented Apr 6, 2023

krystofwoldrich commented Apr 7, 2023

marandaneto commented Apr 7, 2023

chore(native): Add `react-native` postfix to native SDKs #2814

chore(native): Add `react-native` postfix to native SDKs #2814

krystofwoldrich commented Feb 8, 2023 •

edited

Loading

github-actions bot commented Feb 8, 2023 •

edited

Loading

github-actions bot commented Feb 8, 2023 •

edited

Loading

github-actions bot commented Feb 8, 2023 •

edited

Loading