Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark native apply methods as in-app in Expo apps #3286

Open
krystofwoldrich opened this issue Sep 18, 2023 · 0 comments
Open

Don't mark native apply methods as in-app in Expo apps #3286

krystofwoldrich opened this issue Sep 18, 2023 · 0 comments
Assignees
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

Description

Sentry expo rewrite frames integration is modifying some native frames which causes them to be marked as in-app.

sentry-expo https://github.com/expo/sentry-expo/blob/main/src/sentry.ts#L91

Fix from sentry-react-native

if (frame.filename === '[native code]' || frame.filename === 'native') {

@krystofwoldrich krystofwoldrich added Breaking-change should go in a major release (breaks apps, changes default configs in a major way) and removed Breaking-change should go in a major release (breaks apps, changes default configs in a major way) labels Dec 15, 2023
@kahest kahest added Expo Issues related to Sentry React Native Expo support and removed sentry-expo labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native
Projects
Status: Backlog
Development

No branches or pull requests

3 participants