Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry-expo deprecations plans #3262

Closed
21 of 26 tasks
krystofwoldrich opened this issue Aug 31, 2023 · 12 comments
Closed
21 of 26 tasks

sentry-expo deprecations plans #3262

krystofwoldrich opened this issue Aug 31, 2023 · 12 comments
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Aug 31, 2023

sentry-expo is not deprecated yet and fully supports the current React Native 0.72 but likely won't get any new features, those will be added to sentry-react-native. This issue summarizes the deprecation plans.

In Progress

  1. Platform: React-Native Type: Feature Request
  2. bot: fingerprint changed bot: suggestions
  3. bot: fingerprint compatible bot: passed checks published
  4. Platform: React-Native Status: Stale
    krystofwoldrich
  5. krystofwoldrich
  6. krystofwoldrich

MVP to deprecate sentry-expo

  1. kbrandwijk
  2. Platform: React-Native
    krystofwoldrich
  3. Expo Platform: React-Native sentry-expo
    krystofwoldrich
  4. Platform: React-Native
    krystofwoldrich
  5. Expo Platform: React-Native sentry-expo
    krystofwoldrich

Docs updates

  1. bot: passed checks preview

Future expo features

  1. Platform: React-Native
  2. Expo Platform: React-Native Type: Feature Request
  3. Expo Platform: React-Native Type: 🪲 Bug
  4. Platform: React-Native
  5. 5 of 5
    Platform: React-Native
    krystofwoldrich
  6. Platform: React-Native Status: Stale
  7. 0 of 7
    Platform: React-Native

Not planned to be migrated

  • ExpoBareIntegration (frames rewrite will be migrated, for additional tags, extras, and other event data will be supplied guide on how can be added by users)
  • ExpoManagedIntegration (frames rewrite will be migrated, for additional tags, extras, and other event data will be supplied guide on how can be added by users)
  • Post publish hook config used to set Sentry org, project, and authToken (will be replaced by envs or new solution)

Internal Notion notes

@brentvatne
Copy link
Contributor

thanks for putting this together and for the help here @krystofwoldrich! only feedback I have is re: Expo managed frames / Expo bare frames - those names in our sentry-expo repo are kind of misleading so I'll attempt to clarify that here:

the "Expo managed" integration should be called "Expo Go" (this app is a sandbox for learning/experimenting, I think even supporting it in Sentry is optional and I wouldn't be opposed to dropping that)

the "Expo bare" integration could just be called "Expo" (any app with the Expo SDK installed will work the same, no need to differentiate between managed or bare)

@krystofwoldrich
Copy link
Member Author

@brentvatne Thank you for the context, I agree "Expo Go" is a lower priority (as Sentry is oriented on production bugs), but to keep a good dev experience, we would like the JS error captured during development in Expo Go to be correctly reported (source mapped) in Sentry.

@krystofwoldrich krystofwoldrich removed their assignment Oct 9, 2023
@shanamatthews
Copy link

Hey @krystofwoldrich - I'm assuming this will need at least a small docs change to the Expo section of docs. Just want to make sure that's it!

@krystofwoldrich
Copy link
Member Author

@shanamatthews Yes, this will need a few changes in the docs, not only the Expo section but also a migration guide from the sentry-expo package to sentry-react-native.

@felix-lambert
Copy link

felix-lambert commented Nov 10, 2023

@krystofwoldrich Hello the sourcemap is still not being uploaded. Can we have instruction on how to upload the sourcemap with sentry? On older version of expo I didn't have this problem. It has now been a few months i'm using expo and sentry without sourcemaps. The sourcemap seems to upload well on the web app version but not on android or ios :)

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Nov 14, 2023

@felix-lambert Hi, thank you for the message, could you share what Sentry SDK version and Expo version are you using and how you build the app?

The auto upload was fixed in the latest release of https://github.com/expo/sentry-expo/releases/tag/v7.1.1.

@felix-lambert
Copy link

felix-lambert commented Nov 16, 2023

I tried the latest release and it has been fixed. The sourcemap seems to upload well to sentry on android and ios now. Well done ! :)

@kahest kahest added Expo Issues related to Sentry React Native Expo support and removed sentry-expo labels Jan 26, 2024
@krystofwoldrich
Copy link
Member Author

@sentry/react-native now supports Expo out of the box!

Update to https://github.com/getsentry/sentry-react-native/releases/tag/5.16.0 or newer to get all the new features.

Migration guides available:

@natasxa
Copy link

natasxa commented Mar 10, 2024

Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..."
Updated app to expo SDK 50 and now trying to update sentry-expo to @sentry/react-native...

@paulmthiebauth
Copy link

paulmthiebauth commented Mar 15, 2024

Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..." Updated app to expo SDK 50 and now trying to update sentry-expo to @sentry/react-native...

Dealing with the same error right now trying to upgrade SDK. Added entry to plugins in app.config.ts as the migration guide says is fine

@brentvatne
Copy link
Contributor

@natasxa @paulmthiebauth - do you have @sentry/react-native installed in your project? which version?

@natasxa
Copy link

natasxa commented Mar 17, 2024

@brentvatne sure I do, "@sentry/react-native": "5.10.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native
Projects
Archived in project
Archived in project
Development

No branches or pull requests

7 participants