Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console Breadcrumbs - Plan to Re-enable? #685

Closed
4 of 7 tasks
cojo opened this issue Oct 4, 2019 · 4 comments · Fixed by #749
Closed
4 of 7 tasks

Console Breadcrumbs - Plan to Re-enable? #685

cojo opened this issue Oct 4, 2019 · 4 comments · Fixed by #749

Comments

@cojo
Copy link

cojo commented Oct 4, 2019

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native
  • react-native-sentry

react-native version: 0.61.1

Init Code:

Sentry.init({
  dsn: 'https://...@sentry.io/...'
});

It appears that console breadcrumbs were intentionally disabled in the run-up to the 1.0.0 release:

console: false, // If this in enabled it causes problems to native calls on >= RN 0.60

We just upgraded as part of our upgrade to 0.61+ and losing this is a pretty big deal for us as customers of Sentry.

Is there a plan to address / fix whatever breakage required hard-disabling these across the board? If not, can you provide some more detail / context here around how we might investigate / try to workaround this ourselves?

I understand it may not be entirely on the Sentry side of things that the breakage occurred, but it would still be helpful in that case to understand what issue(s) you've filed with the React Native core project and what we should expect here going forwards.

Thanks!

Steps to reproduce:

  • Upgrade to latest @sentry/react-native from previous react-native-sentry.

Actual result:

  • Console breadcrumbs are no longer logged.

Expected result:

  • Console breadcrumbs should continue to be logged as they were previously.
@dgobaud
Copy link

dgobaud commented Oct 21, 2019

yes please! bring it back 😭

@cojo
Copy link
Author

cojo commented Jan 31, 2020

@HazAT
Thanks for adding the labels to this - I was wondering if you might be able to provide any additional context to how re-enabling this feature / functionality is currently prioritized on your backlog and what the expected scope is / what the nature of the issue is?

It'd be helpful as we're evaluating Sentry alternatives to know if this is going to be addressed soon or if it is still not formally on the short- / medium-term roadmap.

Thanks!

@kpheasey
Copy link

kpheasey commented Feb 2, 2020

We found it was better to create our own Logger and use that to handle the necessary Sentry calls. Using your own logger, instead of console.log is also going to be more flexible long term.

Here's a gist with the logger we use to avoid red screen on development and create necessary breadcrumbs via regular logging.

https://gist.github.com/kpheasey/c973cebfd739ca3a21d67c03cdd408fa

@HazAT
Copy link
Member

HazAT commented Feb 11, 2020

This PR re-enables it, will release it soooon
#749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants