feat: Use new Android SDK #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2020
android/build.gradle
Outdated
| @@ -13,20 +13,26 @@ android { | |||
| } | |||
|
|
|||
| defaultConfig { | |||
| minSdkVersion safeExtGet('minSdkVersion', 16) | |||
| minSdkVersion safeExtGet('minSdkVersion', 21) | |||
There was a problem hiding this comment.
We're aiming API 18 on sentry-android-ndk. For sentry-android only it's API 14
There was a problem hiding this comment.
you may keep 16, and do this on manifest -> https://github.com/getsentry/sentry-android/blob/fd6413b92ed97efdecccc1fa6d8abef27fb1c816/sentry-sample/src/main/AndroidManifest.xml#L7
so you support non-ndk from 16 to 20 and with ndk support from 21 on
There was a problem hiding this comment.
no changes needed on manifest, minSdkVersion=16 just works :)
| } | ||
| }, | ||
|
|
||
| platform: Platform.OS |
There was a problem hiding this comment.
What is this platform used for?
marandaneto
reviewed
Jan 27, 2020
marandaneto
reviewed
Jan 27, 2020
marandaneto
reviewed
Jan 27, 2020
# Conflicts: # android/src/main/java/io/sentry/RNSentryModule.java
fix: Native crash handling on android ref: Remove extraUpdated
|
Would this possibly fix the crashes on RN >= 60 mentioned here: https://github.com/getsentry/sentry-react-native/blob/feat/new-android-sdk/src/js/sdk.ts#L47 ? |
|
@wodCZ Done! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742
Fixes #734
Fixes #713
Fixes #695
Fixes #677
Fixes #674
Fixes #667
Fixes #656
Fixes #647
Fixes #623
Fixes #748
Fixes #649
Fixes #757
Fixes #685