Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Align event.origin, event.environment and sdk info with other hybrid sdks #1749

Merged
merged 7 commits into from
Aug 31, 2021
Merged

feat: Align event.origin, event.environment and sdk info with other hybrid sdks #1749

merged 7 commits into from
Aug 31, 2021

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Aug 30, 2021 •
edited by bruno-garcia

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Aligns the values for event.origin and event.environment with what we have on other Hybrid SDKs such as capacitor, cordova, and flutter.

Possible values:

  • event.origin: android, javascript, ios,
  • event.environment: java, native, javascript

Adds the SdkInfo integration so we now add the sdk package info of the native sdks to the event.

馃挕 Motivation and Context

Part of #1701

馃挌 How did you test it?

Wrote unit tests for each of the integrations + tested them on both ios and android sample apps.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes (As we changed the values for the tags, will break users.)

@jennmueng jennmueng self-assigned this Aug 30, 2021
@jennmueng jennmueng added this to In progress in kanban via automation Aug 30, 2021
@jennmueng jennmueng moved this from In progress to Review in progress in kanban Aug 30, 2021
@jennmueng jennmueng marked this pull request as ready for review August 30, 2021 21:52
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2021 •
edited

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against 761f3ab

bruno-garcia
bruno-garcia reviewed Aug 30, 2021
View reviewed changes
ios/RNSentry.m Outdated Show resolved Hide resolved
ios/RNSentry.m Outdated Show resolved Hide resolved
src/js/integrations/sdkinfo.ts Outdated Show resolved Hide resolved
kanban automation moved this from Review in progress to Reviewer approved Aug 31, 2021
bruno-garcia
bruno-garcia approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennmueng jennmueng merged commit f24a3af into master Aug 31, 2021
@jennmueng jennmueng deleted the jenn/event-origin branch August 31, 2021 19:15
kanban automation moved this from Reviewer approved to Done Aug 31, 2021
@bruno-garcia bruno-garcia mentioned this pull request Sep 1, 2021
Closed
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 26, 2021
Merged
@marandaneto marandaneto mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@jennmueng jennmueng

Labels
None yet
Projects
kanban
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jennmueng @bruno-garcia @AbhiPrasad