New arch info to event contexts #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Oct 18, 2022
marandaneto
reviewed
Oct 18, 2022
|
Would be possible to add tests for these changes? |
Android Performance metrics 馃殌
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b5eddfa | 346.86 ms | 367.67 ms | 20.82 ms |
| 70013c7 | 344.17 ms | 358.76 ms | 14.59 ms |
| 3dd1a5b | 337.06 ms | 344.50 ms | 7.44 ms |
| cc863df | 331.40 ms | 350.44 ms | 19.04 ms |
| b4d768b | 316.47 ms | 334.06 ms | 17.59 ms |
| 2a133c2 | 336.00 ms | 341.78 ms | 5.78 ms |
| 17717b8 | 315.32 ms | 329.42 ms | 14.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b5eddfa | 25.82 MiB | 27.86 MiB | 2.04 MiB |
| 70013c7 | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| 3dd1a5b | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| cc863df | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| b4d768b | 25.82 MiB | 27.86 MiB | 2.04 MiB |
| 2a133c2 | 25.82 MiB | 27.86 MiB | 2.04 MiB |
| 17717b8 | 25.82 MiB | 27.86 MiB | 2.04 MiB |
iOS Performance metrics 馃殌
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b5eddfa | 1252.54 ms | 1254.76 ms | 2.22 ms |
| 70013c7 | 1237.84 ms | 1258.46 ms | 20.62 ms |
| 3dd1a5b | 1272.44 ms | 1292.88 ms | 20.44 ms |
| cc863df | 1256.06 ms | 1263.54 ms | 7.48 ms |
| b4d768b | 1236.63 ms | 1257.16 ms | 20.53 ms |
| 2a133c2 | 1232.78 ms | 1238.56 ms | 5.78 ms |
| 17717b8 | 1264.14 ms | 1269.94 ms | 5.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b5eddfa | 1.08 MiB | 1.44 MiB | 367.28 KiB |
| 70013c7 | 1.08 MiB | 1.44 MiB | 371.41 KiB |
| 3dd1a5b | 1.08 MiB | 1.44 MiB | 371.41 KiB |
| cc863df | 1.08 MiB | 1.44 MiB | 371.41 KiB |
| b4d768b | 1.08 MiB | 1.44 MiB | 370.50 KiB |
| 2a133c2 | 1.08 MiB | 1.44 MiB | 370.49 KiB |
| 17717b8 | 1.08 MiB | 1.44 MiB | 363.17 KiB |
|
@marandaneto Tests added. |
marandaneto
reviewed
Oct 19, 2022
marandaneto
reviewed
Oct 19, 2022
marandaneto
reviewed
Oct 19, 2022
marandaneto
reviewed
Oct 19, 2022
marandaneto
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
Send react-native specific runtime information in event contexts.
馃挕 Motivation and Context
Closes: #2162
馃挌 How did you test it?
I've checked on sentry.io that the data is present.
馃摑 Checklist
馃敭 Next steps