fix(gradle): add resolved sentry package for monorepos #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mccraveiro I approved and ran the CI, we will see if it passes, we have e2e build tests that are collecting the modules, so if it works there then it's good. |
|
@krystofwoldrich it seems that I don't have access to some repos necessary for the tests. Do you want me to close this PR so that you can open your own? |
6 tasks
|
Changes are pulled here #3092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2740
📢 Type of change
📜 Description
Dynamically resolve the sentry package dir so that it works with monorepos
💡 Motivation and Context
When using Sentry on monorepos we need to manually set the collectModulesScript path
💚 How did you test it?
I did not :/
Any ideas how can I test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps