Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump android SDK to 6.19.0 & set native SDK name #3086

Merged
merged 3 commits into from
May 24, 2023

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented May 23, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

  • Bumps Android SDK in order to add the feature for renaming the Native SDK.
    Since this change for setting the native SDK name is not listed is not listed on the changelog I believe it should also be ignored here, but if needed feel free to request the change.
  • Set native SDK nave on Android as sentry.native.android.react-native

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Close #2960
#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 333.25 ms 334.96 ms 1.71 ms
Size 17.73 MiB 19.80 MiB 2.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB

Previous results on branch: fix/native-sdk-name

Startup times

Revision Plain With Sentry Diff
a044cfd 276.04 ms 308.24 ms 32.20 ms

App size

Revision Plain With Sentry Diff
a044cfd 17.73 MiB 19.80 MiB 2.07 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.94 ms 1236.50 ms 10.56 ms
Size 2.36 MiB 2.85 MiB 495.32 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1250.92 ms 1252.86 ms 1.94 ms
Size 2.92 MiB 3.41 MiB 499.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB

Previous results on branch: fix/native-sdk-name

Startup times

Revision Plain With Sentry Diff
a044cfd+dirty 1238.84 ms 1242.94 ms 4.10 ms

App size

Revision Plain With Sentry Diff
a044cfd+dirty 2.92 MiB 3.41 MiB 499.09 KiB

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 336.65 ms 358.76 ms 22.11 ms
Size 7.15 MiB 8.07 MiB 946.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB

Previous results on branch: fix/native-sdk-name

Startup times

Revision Plain With Sentry Diff
a044cfd+dirty 270.79 ms 319.63 ms 48.84 ms

App size

Revision Plain With Sentry Diff
a044cfd+dirty 7.15 MiB 8.07 MiB 946.25 KiB

@lucas-zimerman lucas-zimerman marked this pull request as ready for review May 23, 2023 12:01
@@ -113,6 +113,7 @@ public void initNativeSdk(final ReadableMap rnOptions, Promise promise) {
}

options.setSentryClientName(sdkVersion.getName() + "/" + sdkVersion.getVersion());
options.setNativeSdkName("sentry.native.android.react-native");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the already existing variable for the name:

private static final String NATIVE_SDK_NAME = "sentry.native.android";

It's later used for assigning correct origin and environment tags:

case NATIVE_SDK_NAME:
setEventEnvironmentTag(event, "native");
break;

@krystofwoldrich krystofwoldrich changed the title Bump android SDK to 1.19.0 & set native SDK name Bump android SDK to 6.19.0 & set native SDK name May 23, 2023
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG Thank you. 🚀

@krystofwoldrich krystofwoldrich merged commit 34aba08 into main May 24, 2023
41 of 42 checks passed
@krystofwoldrich krystofwoldrich deleted the fix/native-sdk-name branch May 24, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SDK name of Sentry Native for React Native
2 participants