Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): Add source maps upload script #3491

Merged
merged 1 commit into from Jan 8, 2024

Conversation

quinlanj
Copy link
Contributor

@quinlanj quinlanj commented Jan 4, 2024

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Give users an easy way to upload their sourcemaps and bundles to sentry when they publish an OTA update. This script does the following:

  • Resolve sentry project from environment variable or the sentry plugin from expo config
  • Resolve sentry auth token from environment variable
  • Amend sourcemaps to contain debug_id field (sentry servers expect this field)
  • Upload sourcemaps and bundles with sentry-cli

馃挕 usage

SENTRY_AUTH_TOKEN=[super-secret] node node_modules/@sentry/react-native/scripts/expo-upload-sourcemaps.js dist

馃挌 How did you test it?

In test project, I generate the updates with eas update then run the upload script

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

馃敭 Next steps

@krystofwoldrich krystofwoldrich changed the title feat(expo) add sourcemap upload script feat(expo): Add source maps upload script Jan 8, 2024
@krystofwoldrich krystofwoldrich merged commit 6bd18dc into getsentry:expo Jan 8, 2024
1 check failed
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you works perfectly. I've tried it with EAS update and Expo Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants