Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): Use @sentry/react-native/expo as plugin name in expo upload #3515

Merged
merged 2 commits into from Jan 10, 2024

Conversation

krystofwoldrich
Copy link
Member

Although the previous option also works,
we promote in all docs and previous messages/changelogs the /expo export, so we should use it here too.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 402.50 ms 430.11 ms 27.61 ms
Size 17.73 MiB 19.85 MiB 2.11 MiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b 419.25 ms 458.81 ms 39.56 ms

App size

Revision Plain With Sentry Diff
bc4097b 17.73 MiB 19.84 MiB 2.11 MiB

Copy link
Contributor

github-actions bot commented Jan 10, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.13 ms 1223.20 ms 3.08 ms
Size 2.36 MiB 2.88 MiB 526.51 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1223.67 ms 1230.08 ms 6.41 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.36 MiB 2.88 MiB 524.45 KiB

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.45 ms 409.73 ms 31.28 ms
Size 7.15 MiB 8.11 MiB 990.93 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 378.29 ms 413.31 ms 35.01 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 7.15 MiB 8.11 MiB 988.88 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.18 ms 1213.42 ms 2.23 ms
Size 2.92 MiB 3.44 MiB 530.81 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1229.02 ms 1235.65 ms 6.63 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.92 MiB 3.43 MiB 528.75 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit e9e2c8c into expo Jan 10, 2024
66 of 68 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-plugin-name-expo-upload branch January 10, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants