Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add JS Core metrics #3590

Merged
merged 5 commits into from Feb 13, 2024
Merged

Conversation

krystofwoldrich
Copy link
Member

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Adds JS metrics to RN.

馃挕 Motivation and Context

closes: #3578

馃挌 How did you test it?

sample apps

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

馃敭 Next steps

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against f618631

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice being able to leverage core JS!

Copy link
Contributor

iOS (new) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1212.33 ms 1212.35 ms 0.01 ms
Size 2.92 MiB 3.46 MiB 558.96 KiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
2f190d7+dirty 1272.39 ms 1280.80 ms 8.41 ms
5eab2fa+dirty 1284.29 ms 1306.68 ms 22.39 ms
60ceb06+dirty 1242.86 ms 1253.76 ms 10.90 ms
98fe518+dirty 1259.43 ms 1263.60 ms 4.17 ms
9861638+dirty 1209.39 ms 1210.82 ms 1.43 ms
ac92119+dirty 1264.78 ms 1273.36 ms 8.58 ms
de7c573+dirty 1238.06 ms 1242.26 ms 4.20 ms
6f9eae7+dirty 1256.06 ms 1278.59 ms 22.53 ms
8a5e51c+dirty 1259.88 ms 1269.09 ms 9.21 ms
dd975cb+dirty 1242.08 ms 1252.42 ms 10.34 ms

App size

Revision Plain With Sentry Diff
2f190d7+dirty 2.92 MiB 3.44 MiB 535.84 KiB
5eab2fa+dirty 2.92 MiB 3.40 MiB 495.21 KiB
60ceb06+dirty 2.92 MiB 3.41 MiB 499.07 KiB
98fe518+dirty 2.92 MiB 3.40 MiB 488.60 KiB
9861638+dirty 2.92 MiB 3.46 MiB 557.26 KiB
ac92119+dirty 2.92 MiB 3.44 MiB 536.24 KiB
de7c573+dirty 2.92 MiB 3.42 MiB 516.27 KiB
6f9eae7+dirty 2.92 MiB 3.40 MiB 494.93 KiB
8a5e51c+dirty 2.92 MiB 3.41 MiB 499.88 KiB
dd975cb+dirty 2.92 MiB 3.43 MiB 520.26 KiB

@krystofwoldrich
Copy link
Member Author

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich
Copy link
Member Author

Base automatically changed from deps/scripts/update-javascript.sh to main February 13, 2024 15:44
Copy link
Contributor

Android (legacy) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 383.64 ms 392.02 ms 8.38 ms
Size 17.73 MiB 19.91 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3853f43 329.68 ms 346.32 ms 16.64 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms

App size

Revision Plain With Sentry Diff
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1206.57 ms 1208.37 ms 1.80 ms
Size 2.36 MiB 2.90 MiB 554.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

@krystofwoldrich krystofwoldrich merged commit e69e91e into main Feb 13, 2024
48 of 50 checks passed
@krystofwoldrich krystofwoldrich deleted the @krystofwoldrich/add-metrics branch February 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[react-native] Add support for Sentry Metrics
4 participants