Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Option enabled: false ensures no events are sent #3606

Merged
merged 2 commits into from Feb 19, 2024

Conversation

krystofwoldrich
Copy link
Member

馃摙 Type of change

  • Bugfix

馃摐 Description

Introduced in getsentry/sentry-javascript#9101 client.options.enabled check was moved from _processEvent to _sendEnvelope

馃挕 Motivation and Context

馃挌 How did you test it?

sample expo app and unit tests

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

馃敭 Next steps

Copy link
Contributor

Android (legacy) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 449.76 ms 467.68 ms 17.92 ms
Size 17.73 MiB 19.91 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3853f43 329.68 ms 346.32 ms 16.64 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms

App size

Revision Plain With Sentry Diff
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1216.15 ms 1222.38 ms 6.23 ms
Size 2.36 MiB 2.91 MiB 558.14 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the tests 馃憤

@krystofwoldrich krystofwoldrich merged commit adfb66f into main Feb 19, 2024
55 of 57 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-enabled branch February 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable Sentry when in development using Expo?
2 participants