Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(init): Remove deps on internal JS SDK structures #3717

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Mar 26, 2024

This is a preparation for v8 and it's internal changes.

This PR removes dependencies of the test on the internal JS structures.

This makes the test more future-proof and ready for JS V8.

No logic in the test changed.

#skip-changelog

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 421.04 ms 450.52 ms 29.48 ms
Size 17.73 MiB 19.93 MiB 2.20 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 357.57 ms 383.52 ms 25.95 ms
Size 7.15 MiB 8.21 MiB 1.06 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.06 ms 1225.43 ms 6.36 ms
Size 2.36 MiB 2.92 MiB 569.96 KiB

@krystofwoldrich krystofwoldrich changed the base branch from v6 to main April 3, 2024 10:05
@krystofwoldrich krystofwoldrich changed the base branch from main to v6 April 3, 2024 10:06
@krystofwoldrich krystofwoldrich merged commit 2016bc9 into v6 Apr 3, 2024
55 of 57 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-sdk-tests-update branch April 3, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants