feat(ci): Add RN Sample Apple Testflight upload #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
| 6e8584e | 447.10 ms | 474.71 ms | 27.61 ms |
| dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
| 2534337 | 394.15 ms | 415.12 ms | 20.97 ms |
| f06c879 | 408.41 ms | 424.54 ms | 16.13 ms |
| 15c80ab+dirty | 336.27 ms | 350.58 ms | 14.31 ms |
| 76d1baf+dirty | 335.72 ms | 355.52 ms | 19.80 ms |
| 9c48b2c | 349.24 ms | 385.96 ms | 36.72 ms |
| 0677344 | 327.74 ms | 337.14 ms | 9.40 ms |
| 5446992 | 403.40 ms | 426.70 ms | 23.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 6e8584e | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 2534337 | 17.73 MiB | 19.84 MiB | 2.11 MiB |
| f06c879 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
| 15c80ab+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 76d1baf+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 9c48b2c | 17.73 MiB | 19.80 MiB | 2.07 MiB |
| 0677344 | 17.73 MiB | 19.81 MiB | 2.07 MiB |
| 5446992 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f06c879+dirty | 361.27 ms | 407.88 ms | 46.61 ms |
| d197b5c+dirty | 258.75 ms | 313.61 ms | 54.86 ms |
| 1d86dd6+dirty | 335.76 ms | 371.22 ms | 35.46 ms |
| dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
| 728164b+dirty | 335.93 ms | 342.94 ms | 7.01 ms |
| e2b64fe+dirty | 258.82 ms | 304.26 ms | 45.44 ms |
| 0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
| d361d38+dirty | 257.72 ms | 318.76 ms | 61.04 ms |
| ad6c299+dirty | 336.47 ms | 362.89 ms | 26.42 ms |
| 27ef4ee+dirty | 296.71 ms | 351.00 ms | 54.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f06c879+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
| d197b5c+dirty | 7.15 MiB | 8.09 MiB | 962.72 KiB |
| 1d86dd6+dirty | 7.15 MiB | 8.13 MiB | 1002.18 KiB |
| dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
| 728164b+dirty | 7.15 MiB | 8.12 MiB | 997.71 KiB |
| e2b64fe+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
| 0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
| d361d38+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
| ad6c299+dirty | 7.15 MiB | 8.04 MiB | 912.17 KiB |
| 27ef4ee+dirty | 7.15 MiB | 8.08 MiB | 959.49 KiB |
krystofwoldrich
changed the base branch from
kw-add-samples-versioning
to
kw-add-sample-app-icon
|
DO NOT MERGE, I'm currently testing different way to include the privacy manifest to see what Apple accepts and what not. |
This reverts commit 9b52123.
brustolin
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds upload of the Sentry Bare RN sample to testflight on every commit to main.
Needs
com.sampleNewArchitecturetoio.sentry.reactnative.sample#3762#skip-changelog