feat(core): Bump sentry-javascript to version 8 #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android (legacy) Performance metrics 馃殌
|
krystofwoldrich
changed the title
2 tasks
mydea
reviewed
May 27, 2024
mydea
reviewed
May 27, 2024
mydea
reviewed
May 27, 2024
mydea
reviewed
May 27, 2024
src/js/profiling/integration.ts
Outdated
| @@ -172,16 +195,16 @@ export const hermesProfilingIntegration: IntegrationFn = () => { | |||
| }; | |||
|
|
|||
| const _createProfileEventFor = (profiledTransaction: Event): ProfileEvent | null => { | |||
| const profile_id = profiledTransaction?.contexts?.['profile']?.['profile_id']; | |||
| const profile_id = profiledTransaction?.contexts?.['trace']?.['data']?.['profile_id']; | |||
There was a problem hiding this comment.
Should we refer to profiledTransaction as profiledEvent or profiledSpan since transactions are no longer used?
There was a problem hiding this comment.
Yes, make sense, I agree, but let's do it in another PR, to avoid adding more change to this, it's already a large PR.
Android (new) Performance metrics 馃殌
|
| this._initNativeSdk(); | ||
| super.init(); |
There was a problem hiding this comment.
Q: Was it previously wrong and you fix it now or is it a change that was required for V8?
There was a problem hiding this comment.
The init was added for V8, the native init needs to happen before the JS init, to avoid the native not available error log in Expo.
Before v8 the native init happened in constructor, which doesn't make sense with dedicate init method.
lucas-zimerman
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
sentry-javascriptto version 8聽#3736馃挌 How did you test it?
馃摑 Checklist
sendDefaultPIIis enabled馃敭 Next steps
#skip-changelog