Add sampled field to dynamic_sampling_context (#2092)

getsentry · Aug 21, 2023 · 86dfaea · 86dfaea
1 parent 8abb2d2
commit 86dfaea
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Features
 
 - Make `:value` in `SingleExceptionInterface` writable, so that it can be modified in `before_send` under `event.exception.values[n].value` [#2072](https://github.com/getsentry/sentry-ruby/pull/2072)
+- Add `sampled` field to `dynamic_sampling_context` [#2092](https://github.com/getsentry/sentry-ruby/pull/2092)
 - Add new `config.trace_propagation_targets` option to set targets for which headers are propagated in outgoing HTTP requests [#2079](https://github.com/getsentry/sentry-ruby/pull/2079)
 
   ```rb

diff --git a/sentry-ruby/lib/sentry/transaction.rb b/sentry-ruby/lib/sentry/transaction.rb
@@ -323,6 +323,7 @@ def populate_head_baggage
       items = {
         "trace_id" => trace_id,
         "sample_rate" => effective_sample_rate&.to_s,
+        "sampled" => sampled&.to_s,
         "environment" => @environment,
         "release" => @release,
         "public_key" => @dsn&.public_key

diff --git a/sentry-ruby/spec/sentry/client_spec.rb b/sentry-ruby/spec/sentry/client_spec.rb
@@ -156,6 +156,7 @@ def sentry_context
         "environment" => "development",
         "public_key" => "12345",
         "sample_rate" => "1.0",
+        "sampled" => "true",
         "transaction" => "test transaction",
         "trace_id" => transaction.trace_id
       })

diff --git a/sentry-ruby/spec/sentry/net/http_spec.rb b/sentry-ruby/spec/sentry/net/http_spec.rb
@@ -124,6 +124,7 @@
       expect(request["baggage"]).to eq(
         "sentry-trace_id=#{transaction.trace_id},"\
         "sentry-sample_rate=1.0,"\
+        "sentry-sampled=true,"\
         "sentry-environment=development,"\
         "sentry-public_key=foobarbaz"
       )

diff --git a/sentry-ruby/spec/sentry/transaction_spec.rb b/sentry-ruby/spec/sentry/transaction_spec.rb
@@ -537,7 +537,8 @@
           "public_key" => "12345",
           "trace_id" => subject.trace_id,
           "transaction"=>"foo",
-          "sample_rate" => "1.0"
+          "sample_rate" => "1.0",
+          "sampled" => "true"
         })
       end
 
@@ -592,7 +593,8 @@
           "public_key" => "12345",
           "trace_id" => subject.trace_id,
           "transaction"=>"foo",
-          "sample_rate" => "1.0"
+          "sample_rate" => "1.0",
+          "sampled" => "true"
         })
       end
     end