New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option skip_rake_integration #1453
Add configuration option skip_rake_integration #1453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay and thanks for the PR 🙏
just 2 minor changes then I think it'll be good to merge.
also, can you add a changelog entry for this?
@@ -429,4 +429,12 @@ class SentryConfigurationSample < Sentry::Configuration | |||
expect(instance.var2). to eq 2 | |||
end | |||
end | |||
|
|||
describe "#skip_rake_integration" do | |||
it "returns true" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add another one to confirm that its default is false
@@ -9,3 +9,10 @@ | |||
task :raise_exception do | |||
1/0 | |||
end | |||
|
|||
task :raise_exception_without_rake_integration do | |||
Sentry.init do |config| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the SDK is already initialized, this can be Sentry.configuration.skip_rake_integration = true
@westonganger actually, I'll cut a release today so I'll change them manually and make it in 4.5.0 as well 🙂 |
Add configuration option
skip_rake_integration
. As mentioned in #1378 (comment)