Add workaround for ConnectionStub's missing interface #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionCable's ConnectionStub (for testing) doesn't implement the exact same interfaces as Connection::Base. One thing that's missing is `env`. So calling `connection.env` direclty will fail in test environments when `stub_connection` is used. See #1684 for more information.
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
+ Coverage 98.46% 98.55% +0.09%
==========================================
Files 136 136
Lines 7667 7691 +24
==========================================
+ Hits 7549 7580 +31
+ Misses 118 111 -7
Continue to review full report at Codecov.
|
sl0thentr0py
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionCable's
ConnectionStub(for testing) doesn't implement the exact same interfaces asConnection::Base.One thing that's missing is
env. So callingconnection.envdireclty will fail in test environments whenstub_connectionis used.See #1684 for more information.
Closes #1685.