Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for ConnectionStub's missing interface #1686

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Add workaround for ConnectionStub's missing interface #1686

merged 3 commits into from
Jan 14, 2022

Commits on Jan 14, 2022

  1. Add specs for ActionCable's connection handling

    @st0012
    st0012 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8a15de1 View commit details
    Browse the repository at this point in the history

  2. Add workaround for ActionCable's ConnectionStub 

    ActionCable's ConnectionStub (for testing) doesn't implement the exact same interfaces as Connection::Base.
One thing that's missing is `env`. So calling `connection.env` direclty will fail in test environments when `stub_connection` is used.
See #1684 for more information.
    @st0012
    st0012 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    fee75a4 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @st0012
    st0012 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    849f7a6 View commit details
    Browse the repository at this point in the history