Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users about config.async's deprecation #1803

Merged
merged 3 commits into from
May 3, 2022
Merged

Warn users about config.async's deprecation #1803

merged 3 commits into from
May 3, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Apr 30, 2022

Since we're going to drop config.async in 6.0 (as explained in #1522), I think we should start warning users about the change.

I did my best to make the message clear and compact, but it'd be great if we can have real professionals to polish it a bit 🙂

@st0012 st0012 added this to the 5.4.0 milestone Apr 30, 2022
@st0012 st0012 self-assigned this Apr 30, 2022
@st0012 st0012 added this to In progress in 5.x via automation Apr 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #1803 (f3b17fb) into master (7429e6c) will decrease coverage by 1.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1803      +/-   ##
==========================================
- Coverage   98.42%   96.55%   -1.88%     
==========================================
  Files         145      120      -25     
  Lines        8588     7308    -1280     
==========================================
- Hits         8453     7056    -1397     
- Misses        135      252     +117     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.43% <100.00%> (+<0.01%) ⬆️
sentry-rails/lib/sentry/rails/railtie.rb 26.02% <0.00%> (-71.24%) ⬇️
sentry-rails/lib/sentry/rails/tracing.rb 34.21% <0.00%> (-65.79%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 37.83% <0.00%> (-62.17%) ⬇️
...entry-rails/lib/sentry/rails/capture_exceptions.rb 36.00% <0.00%> (-60.00%) ⬇️
sentry-rails/lib/sentry/rails/backtrace_cleaner.rb 47.05% <0.00%> (-52.95%) ⬇️
.../lib/sentry/rails/rescued_exception_interceptor.rb 50.00% <0.00%> (-50.00%) ⬇️
...ntry/rails/tracing/action_controller_subscriber.rb 52.94% <0.00%> (-47.06%) ⬇️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 37.03% <0.00%> (-37.04%) ⬇️
.../sentry/rails/tracing/active_storage_subscriber.rb 63.63% <0.00%> (-36.37%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7429e6c...f3b17fb. Read the comment docs.

@st0012 st0012 requested a review from sl0thentr0py May 3, 2022 08:47
st0012 and others added 2 commits May 3, 2022 16:48
Co-authored-by: Neel Shah <neel.shah@sentry.io>
@st0012 st0012 merged commit eb8c598 into master May 3, 2022
5.x automation moved this from In progress to Done May 3, 2022
@st0012 st0012 deleted the deprecate-async branch May 3, 2022 08:58
@st0012 st0012 modified the milestones: 5.4.0, 5.3.1 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants