Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users about config.async's deprecation #1803

Merged
merged 3 commits into from
May 3, 2022
Merged

Warn users about config.async's deprecation #1803

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3b17fb
Warn users about config.async's deprecation
st0012 Apr 30, 2022
84cc8fd
Update sentry-ruby/lib/sentry/configuration.rb
st0012 May 3, 2022
0946405
Update changelog
st0012 May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sentry-ruby/lib/sentry/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,16 @@ def dsn=(value)
def async=(value)
check_callable!("async", value)

log_warn <<~MSG

sentry-ruby now sends events asynchronously by default with its backgrounrd worker (supported since 4.1.0).
st0012 marked this conversation as resolved.
Show resolved Hide resolved
The `config.async` callback has become redundant while continuing to cause issues.
(The problems of `async` are detailed in https://github.com/getsentry/sentry-ruby/issues/1522)

Therefore, we encourage you to remove it and let the background worker take care of async job sending.
It's deprecation is planned in the next major release (6.0), which is scheduled around the 3rd quarter of 2022.
MSG

@async = value
end

Expand Down