Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a DB connection, but release one if it is acquired #1812

Merged
merged 1 commit into from
May 7, 2022
Merged

Don't require a DB connection, but release one if it is acquired #1812

merged 1 commit into from
May 7, 2022

Conversation

jakeonfire
Copy link
Contributor

@jakeonfire jakeonfire commented May 7, 2022

solves #1808 which evolved from #1320. tip from https://stackoverflow.com/a/26733385.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1812 (e22dd5d) into master (fb80e1f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1812      +/-   ##
==========================================
- Coverage   98.45%   98.45%   -0.01%     
==========================================
  Files         145      145              
  Lines        8589     8587       -2     
==========================================
- Hits         8456     8454       -2     
  Misses        133      133              
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/background_worker.rb 100.00% <100.00%> (+14.28%) ⬆️
sentry-resque/lib/sentry/resque.rb 97.14% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb80e1f...e22dd5d. Read the comment docs.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked that #with_connection uses #release_connection underneath, so calling it directly is even better. Thanks for the fix 👍

@st0012 st0012 added this to In progress in 5.x via automation May 7, 2022
@st0012 st0012 added this to the 5.4.0 milestone May 7, 2022
@st0012 st0012 merged commit bcfdec5 into getsentry:master May 7, 2022
5.x automation moved this from In progress to Done May 7, 2022
@st0012 st0012 modified the milestones: 5.4.0, 5.3.1 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants