Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require a DB connection, but release one if it is acquired #1812

Merged
merged 1 commit into from
May 7, 2022
Merged

Don't require a DB connection, but release one if it is acquired #1812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 4 additions & 9 deletions sentry-rails/lib/sentry/rails/background_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
module Sentry
class BackgroundWorker
def _perform(&block)
# some applications have partial or even no AR connection
if ActiveRecord::Base.connected?
# make sure the background worker returns AR connection if it accidentally acquire one during serialization
ActiveRecord::Base.connection_pool.with_connection do
block.call
end
else
block.call
end
block.call
ensure
# make sure the background worker returns AR connection if it accidentally acquire one during serialization
ActiveRecord::Base.connection_pool.release_connection
end
end
end