Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Rails 7.1's test app separately #1901

Merged
merged 1 commit into from Sep 19, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 17, 2022

Rails 7.1 stores the error reporter directly under the ActiveSupport class (PR: rails/rails#46029). So we need to make sure the subscriber is not subscribed unexpectedly before any tests.

And because both the change and the unsubscribe API is introduced in Rails 7.1, we should start having a dedicated test setup for it now.

@st0012 st0012 self-assigned this Sep 17, 2022
@st0012 st0012 added this to In progress in 5.x via automation Sep 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Base: 98.40% // Head: 98.38% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (481358a) compared to base (ae13d7d).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
- Coverage   98.40%   98.38%   -0.03%     
==========================================
  Files         148      148              
  Lines        8891     8893       +2     
==========================================
  Hits         8749     8749              
- Misses        142      144       +2     
Impacted Files Coverage Δ
sentry-rails/spec/dummy/test_rails_app/app.rb 89.70% <25.00%> (-2.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012
Copy link
Collaborator Author

st0012 commented Sep 19, 2022

ping @sl0thentr0py

@st0012 st0012 merged commit d83b29c into master Sep 19, 2022
5.x automation moved this from In progress to Done Sep 19, 2022
@st0012 st0012 deleted the configure-rails-7-1-separately branch September 19, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants