Add assert_error_reported and assert_no_error_reported
#46029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
error-assertions
branch
2 times, most recently
from
6b30197
to
3b52bea
Compare
casperisfine
commented
Sep 14, 2022
| @@ -95,6 +95,7 @@ def self.eager_load! | |||
| cattr_accessor :test_order # :nodoc: | |||
| cattr_accessor :test_parallelization_threshold, default: 50 # :nodoc: | |||
|
|
|||
| @error_reporter = ActiveSupport::ErrorReporter.new | |||
There was a problem hiding this comment.
This is changing a bit how the error reporter works. Now it's just always available on ActiveSupport.error_reporter and all other ways to access it are just delegators.
activesupport/lib/active_support/testing/error_reporter_assertions.rb
Outdated
Show resolved
Hide resolved
casperisfine
force-pushed
the
error-assertions
branch
from
3b52bea
to
62fb29b
Compare
rafaelfranca
approved these changes
Sep 15, 2022
Allows to easily asserts an error happened but was handled ```ruby report = assert_error_reported(IOError) do # ... end assert_equal "Oops", report.error.message assert_equal "admin", report.context[:section] assert_equal :warning, report.severity assert_predicate report, :handled? ```
casperisfine
force-pushed
the
error-assertions
branch
from
62fb29b
to
f33a1b9
Compare
hachi8833
added a commit
to hachi8833/rails
that referenced
this pull request
Sep 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to easily asserts an error happened but was handled
The matching is on purpose limited to a single class matching, at least in the documentation, as I don't think it would be a good idea to add more complex matchers, as they would get unwidly.
That being said, I use
===for matching, so you could pass a proc to do more complex matching, it would be not handle nothing matching properly.