Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sidekiq tracing headers not being overwritten in case of schedules and retries #2118

Merged
merged 1 commit into from Sep 28, 2023
Merged

Fix Sidekiq tracing headers not being overwritten in case of schedules and retries #2118

merged 1 commit into from Sep 28, 2023

Commits on Sep 28, 2023

  1. Fix Sidekiq tracing headers not being overwritten in case of schedule… 

    …s and retries [#2118](#2118)

#1774 added
`SentryContextClientMiddleware` to the server middleware chain too.

Sidekiq's scheduler pushes to the client on the server again for
schedules and retries which causes our trace propagation to be broken
for this case.
https://github.com/sidekiq/sidekiq/blob/aadc77a172f1490fb141c7936d2801ca3af925ef/lib/sidekiq/scheduled.rb#L39

Prioritize taking the trace propagation headers from the job whenever
they exist.
    @sl0thentr0py
    sl0thentr0py committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0f25262 View commit details
    Browse the repository at this point in the history