Make links more specific in gemspecs #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add subdir with the gem. 2. Add specific version.
sl0thentr0py
force-pushed
the
make_links_more_specific_in_gemspecs
branch
from
e4a778d
to
3714e23
Compare
sl0thentr0py
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure should I add an entry to the changelogs, and each of them or just one.
Description
I believe each separate gem should have correct (direct, specific) links in its gemspec. In this architecture with single-repo it's achievable. Also it'll help us to list dependencies in our project without common duplicates to the root of the repo.
Additionally gems with specific version (such as
5.17.3) should point to documentation, changelog, sources, etc. of this version, not upstream (master).Also links to
rubydoc.infoand GitHub issues were added.#skip-changelog