Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for rack 3.1 #2327

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix CI for rack 3.1 #2327

merged 1 commit into from
Jun 24, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jun 24, 2024

they just changed how MockRequest works, nothing else breaking afaict

closes #2325

#skip-changelog

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (389395e) to head (05bc900).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2327       +/-   ##
===========================================
+ Coverage   78.30%   98.65%   +20.35%     
===========================================
  Files         146      205       +59     
  Lines        6890    13486     +6596     
===========================================
+ Hits         5395    13305     +7910     
+ Misses       1495      181     -1314     
Components Coverage Δ
sentry-ruby 99.02% <100.00%> (+44.05%) ⬆️
sentry-rails 97.41% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (-0.33%) ⬇️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
...y/spec/sentry/interfaces/request_interface_spec.rb 99.09% <100.00%> (ø)

... and 125 files with indirect coverage changes

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@sl0thentr0py sl0thentr0py merged commit cfc2570 into master Jun 24, 2024
124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-rack-3.1 branch June 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rack 3.1
2 participants