Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not panic on invalid Proxy #450

Merged
merged 2 commits into from
Apr 26, 2022
Merged

fix: Do not panic on invalid Proxy #450

merged 2 commits into from
Apr 26, 2022

Conversation

Swatinem
Copy link
Member

Interestingly, the surf transport does not support proxy settings at all.

fixes #447 and fixes #448

@Swatinem Swatinem requested a review from a team March 25, 2022 09:49
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #450 (99800b7) into master (799f211) will decrease coverage by 0.15%.
The diff coverage is 18.91%.

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   80.43%   80.28%   -0.16%     
==========================================
  Files          73       73              
  Lines        8364     8389      +25     
==========================================
+ Hits         6728     6735       +7     
- Misses       1636     1654      +18     

@grant0417
Copy link

Any progress on getting this merged?

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only wonder if the reporting should be on error-level rather than debug? I don't have a strong opinion though.

@Swatinem Swatinem enabled auto-merge (squash) April 26, 2022 09:08
@Swatinem Swatinem merged commit 7e6df65 into master Apr 26, 2022
@Swatinem Swatinem deleted the fix/invalid-proxy branch April 26, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http_proxy panic Panic in sentry::init
4 participants