feat(profiling): Add support for Profiling #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to exclude compilation of nix dependent code on windows
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 81.23% 79.51% -1.73%
==========================================
Files 74 76 +2
Lines 8846 9054 +208
==========================================
+ Hits 7186 7199 +13
- Misses 1660 1855 +195 |
Swatinem
reviewed
Jun 28, 2022
There was a problem hiding this comment.
This looks promising. I scattered some suggestions around. Essentially I would love this to move into its own module, and have a fn start_profiling() -> Option<ProfileGuard>, and maybe a fn stop_profiling(ProfileGuard) -> Profile (the envelope item) as the two functions that you call from the performance module.
* refactor into a profiling.rs module * remove lazy_Static and mut_static * replace mutex with AtomicBool * remove profiling feature from test
Swatinem
approved these changes
Jun 30, 2022
| }) | ||
| .collect(); | ||
|
|
||
| samples.push(Sample { |
There was a problem hiding this comment.
You can also use a rep.data.keys().map(…).collect() instead of the Vec::new + push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the profiling feature.
For this first iteration we will stick to the design implementation of the mobile profilers (
Android/iOS) with one profile being linked to one transaction.enable_profilingoption to enable/disable profilingprofiles_sample_rateoption to further sample profiles with respect to the transactions. This is dependent ontraces_sample_rateand the probability of a profile being collected is:traces_sample_rate * profiles_sample_rate