Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic E2E test #277

Merged
merged 26 commits into from Nov 29, 2019
Merged

Add basic E2E test #277

merged 26 commits into from Nov 29, 2019

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Nov 25, 2019

This basic test will fix integration issues with the framework like the one in #266 (comment)

@Jean85 Jean85 added this to the 3.2 milestone Nov 25, 2019
@Jean85 Jean85 self-assigned this Nov 25, 2019
@Jean85
Copy link
Collaborator Author

Jean85 commented Nov 27, 2019

Only failure in CI seems to be only when using sentry/sentry from develop, due to getsentry/sentry-php#919

I've opened #279 to track that, so we can ignore that failure.

@Jean85 Jean85 mentioned this pull request Nov 28, 2019
@OO00O0O
Copy link

OO00O0O commented Nov 29, 2019

Please guys @HazAT or @stayallive

@Jean85
Copy link
Collaborator Author

Jean85 commented Nov 29, 2019

Latest commit broke the build 🤦‍♂️

I think we need to say bye-bye to Symfony 2.8 along with everything < 3.4; they're no longer supported too!

@Jean85 Jean85 mentioned this pull request Nov 29, 2019
@Jean85 Jean85 modified the milestones: 3.2, 3.3 Nov 29, 2019
@Jean85 Jean85 merged commit 7b2f5b0 into master Nov 29, 2019
@Jean85 Jean85 deleted the add-integration-test branch November 29, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants