Add support for Symfony 5 #266

Big-Shark · 2019-10-25T15:00:26Z

No description provided.

Jean85

Since it's coming in the next 30 days, this is probably a good time to do it.

Please add an entry in the changelog!

Big-Shark · 2019-10-28T20:04:16Z

@Jean85 Done

Big-Shark · 2019-11-21T20:16:16Z

@Jean85 Your move )

Jean85 · 2019-11-22T17:56:07Z

Sorry I'm at SymfonyCon so I didn't had the time to check it 😄 But I saw the release live 🎉

I'm going to re-start the CI to see if everything is ok....

Jean85

PR seems fine, but unfortunately it seems that we're blocked upstream: getsentry/sentry-php#925 (review)

rvanlaak · 2019-11-25T08:53:50Z

We had the following error after installing it on a Symfony 5 project, so an additional forward-compatibility fix seems needed:

Jean85 · 2019-11-25T14:05:04Z

We're missing an integration test, that's why we missed this 😢

I'll need to setup a test like that before going forward.

Jean85 · 2019-12-03T10:16:04Z

Symfony 5 is still not getting installed 😢 There's something amiss with the CI config. I'll try to force it somehow.

Jean85 · 2019-12-05T23:38:23Z

Conflict solved, build is failing :(

DavidBadura · 2019-12-06T10:30:16Z

Hey, thank you for trying to push this PR forward! <3 I'm trying to help:

You have requested a non-existent parameter "kernel.root_dir". Did you mean one of these: "kernel.project_dir", "kernel.cache_dir", "kernel.logs_dir"?

You need to change kernel.root_dir to kernel.project_dir. kernel.root_dir is deprecated since SF4.2 and removed in SF5.0. kernel.project_dir exists since SF3.3.

Could not reflect class Symfony\Component\Console\Event\ConsoleCommandEvent as it is marked final.

You do not have to mock value objects. You can just instantiate them. These include:

Request
Token
*Event like ConsoleCommandEvent

Of course, you can mock the service away.

If you want, I can try to finish this PR on the weekend.

Big-Shark · 2019-12-06T11:27:59Z

@DavidBadura yes please, do it.

Jean85 · 2019-12-06T16:31:42Z

Thanks @DavidBadura for the suggestions, I've implemented it. I've also removed some pieces of code that were needed for Symfony < 3.3.

Jean85 · 2019-12-06T17:11:58Z

I should've fixed all the tests. Now onto fixing PHPStan.

Vincz · 2019-12-09T13:32:06Z

@Jean85 Hey! The remaining errors seems related to the PHP Unit version. The current version is 8.5 while the bundle uses the 7.5

Jean85 · 2019-12-09T13:38:35Z

In reality I did a mistake with the class aliases. I fear that something else is still missing, let's see the CI after this fix...

cleentfaar · 2019-12-09T15:25:45Z

@Jean85 need help?

Jean85 · 2019-12-09T15:48:23Z

I'm currently getting deprecation errors under PHP 7.4, probably from PHPUnit. I'll try to use the PHPUnit bridge to allow PHPUnit 8

Jean85 · 2019-12-09T16:13:09Z

Ok two other issues:

I'm still getting deprecations under 7.4, I can't trace them :( any suggestion? https://travis-ci.org/getsentry/sentry-symfony/jobs/622739268#L787-L788
@garak your sed is "updating" the PHPUnit bridge too, how can I ignore it too? https://travis-ci.org/getsentry/sentry-symfony/jobs/622739265#L643

garak · 2019-12-09T16:15:25Z

@Jean85 I see that phpunit-bridge has "normal" versions, why do you want to ignore it in sed replace?

garak · 2019-12-09T16:27:30Z

@Jean85 deprecation could be probably solved by allowing phpunit 8

jderusse

to fix phpunit deprecation, I use rector rector process --set phpunit8.0 .

jderusse · 2019-12-09T17:56:25Z

composer.json

-        "symfony/browser-kit": "^3.4||^4.0",
-        "symfony/expression-language": "^3.4||^4.0",
-        "symfony/framework-bundle": "^3.4||^4.0",
+        "phpunit/phpunit": "^7.5||^8.5",


remove this, and let symfony/phpunit-bridge pick the right version ./vendor/bin/simple-phpunit

jderusse · 2019-12-09T17:57:19Z

test/EventListener/RequestListenerTest.php

    private $currentScope;
    private $currentHub;
    private $options;

-    protected function setUp()
+    protected function doSetUp(): void


not needed, because the projet require php ^7.1n you can saftly add the typehint here setUp(): void

Jean85 · 2019-12-09T21:22:33Z

Because the trait is missing. But as per #266 (comment), I may not need it. BTW the PHPUnit bridge has no requirements, so you do not need to downgrade it.

Jean85 · 2019-12-09T22:14:03Z

PHP 7.4 deprecations will be fixed by getsentry/sentry-php#930 upstream.

Jean85

It finally works!

Remaining deprecations will be fixed when getsentry/sentry-php#930 will be tagged.

rvanlaak · 2019-12-11T12:39:05Z

@Jean85 great job everyone! 👏 Planning on releasing soon? If not I'll verify by requiring master locally.

Jean85 · 2019-12-11T12:40:26Z

Normally @HazAT is in charge of releasing. Feel free to test it out!

Add support for Symfony 5

f599f82

Jean85 requested changes Oct 28, 2019

View reviewed changes

Update CHANGELOG.md

91abf5a

Big-Shark requested a review from Jean85 October 28, 2019 21:05

chindit approved these changes Nov 21, 2019

View reviewed changes

This was referenced Nov 22, 2019

Symfony 5 compatibility #276

Closed

Add support for Symfony 5 #272

Closed

Jean85 requested changes Nov 22, 2019

View reviewed changes

Jean85 mentioned this pull request Nov 25, 2019

Add basic E2E test #277

Merged

rvanlaak mentioned this pull request Nov 26, 2019

Symfony 5 compatibility getsentry/sentry-php#925

Merged

TomasVotruba mentioned this pull request Nov 27, 2019

Update to Symfony 5 pehapkari/pehapkari.cz#243

Merged

3 tasks

jderusse mentioned this pull request Nov 28, 2019

Remove deprecated listener events #281

Closed

Jean85 added this to the 3.3 milestone Nov 29, 2019

Merge branch 'master' into patch-1

4e7c35d

Jean85 mentioned this pull request Dec 2, 2019

Use PHPStan shim to anticipate 0.12 release and avoid require conflicts #284

Merged

Merge branch 'master' into patch-1

01393fc

Jean85 added 3 commits December 6, 2019 17:26

Remove Symfony < 3.3 compat code

c4b8ebd

Do not mock event in test

afcdd5f

Remove more instances of %kernel.root_dir%

ebf4f56

Fix tests and add alias for deprecated GetResponseEvent class

8679d5a

Jean85 added 4 commits December 6, 2019 17:56

Fix tests and add alias for deprecated FilterControllerEvent class

36a43b5

Fix tests and add alias for deprecated events in SubrequestListener

f79ae92

Fix mistake about ResponseEvent -> RequestEvent

25578dc

Fix deprecation of client in E2E tests

e82a73e

Jean85 added 2 commits December 6, 2019 18:18

Try to fix routing config loading in E2E tests

ce8dad8

Avoid deprecation in E2E config

dd15d64

Fix class aliases

5dfaf9e

Jean85 added 2 commits December 9, 2019 14:49

Revert wrong fix

53192bd

Fix event names

247b867

Allow PHPUnit 8

f9af9f5

jderusse reviewed Dec 9, 2019

View reviewed changes

Avoid using trait for test compat

f316cb3

Ignore deprecations coming from Symfony 3.4

b6276c2

Jean85 force-pushed the patch-1 branch from f8236d6 to b6276c2 Compare December 10, 2019 11:43

Disable deprecations completely under Symfony 3.4

103523d

Jean85 approved these changes Dec 11, 2019

View reviewed changes

Jean85 merged commit 7532496 into getsentry:master Dec 11, 2019

rvanlaak mentioned this pull request Dec 11, 2019

fix PHPUnit 9 deprecations #288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Symfony 5 #266

Add support for Symfony 5 #266

Big-Shark commented Oct 25, 2019

Jean85 left a comment

Big-Shark commented Oct 28, 2019

Big-Shark commented Nov 21, 2019

Jean85 commented Nov 22, 2019

Jean85 left a comment

rvanlaak commented Nov 25, 2019

Jean85 commented Nov 25, 2019

Jean85 commented Dec 3, 2019

Jean85 commented Dec 5, 2019

DavidBadura commented Dec 6, 2019

Big-Shark commented Dec 6, 2019

Jean85 commented Dec 6, 2019

Jean85 commented Dec 6, 2019

Vincz commented Dec 9, 2019

Jean85 commented Dec 9, 2019

cleentfaar commented Dec 9, 2019

Jean85 commented Dec 9, 2019

Jean85 commented Dec 9, 2019

garak commented Dec 9, 2019

garak commented Dec 9, 2019

jderusse left a comment

jderusse Dec 9, 2019

jderusse Dec 9, 2019

Jean85 commented Dec 9, 2019

Jean85 commented Dec 9, 2019

Jean85 left a comment

rvanlaak commented Dec 11, 2019 •

edited

Jean85 commented Dec 11, 2019

Add support for Symfony 5 #266

Add support for Symfony 5 #266

Conversation

Big-Shark commented Oct 25, 2019

Jean85 left a comment

Choose a reason for hiding this comment

Big-Shark commented Oct 28, 2019

Big-Shark commented Nov 21, 2019

Jean85 commented Nov 22, 2019

Jean85 left a comment

Choose a reason for hiding this comment

rvanlaak commented Nov 25, 2019

Jean85 commented Nov 25, 2019

Jean85 commented Dec 3, 2019

Jean85 commented Dec 5, 2019

DavidBadura commented Dec 6, 2019

Big-Shark commented Dec 6, 2019

Jean85 commented Dec 6, 2019

Jean85 commented Dec 6, 2019

Vincz commented Dec 9, 2019

Jean85 commented Dec 9, 2019

cleentfaar commented Dec 9, 2019

Jean85 commented Dec 9, 2019

Jean85 commented Dec 9, 2019

garak commented Dec 9, 2019

garak commented Dec 9, 2019

jderusse left a comment

Choose a reason for hiding this comment

jderusse Dec 9, 2019

Choose a reason for hiding this comment

jderusse Dec 9, 2019

Choose a reason for hiding this comment

Jean85 commented Dec 9, 2019

Jean85 commented Dec 9, 2019

Jean85 left a comment

Choose a reason for hiding this comment

rvanlaak commented Dec 11, 2019 • edited

Jean85 commented Dec 11, 2019

rvanlaak commented Dec 11, 2019 •

edited