fix: More explicit Build Time Options Configuration
#1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
commented
Feb 21, 2023
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs
Outdated
Show resolved
Hide resolved
…ry-unity into fix/rename-config
bitsandfoxes
changed the title
Build Time Options Configuration
| type: 2} | ||
| <BuildtimeOptionsConfiguration>k__BackingField: {fileID: 11400000, guid: 6bcc81a646c08ce439ab03805d477458, | ||
| <BuildTimeOptionsConfiguration>k__BackingField: {fileID: 11400000, guid: 1c61999bd2a61408393cfe218d42287e, |
There was a problem hiding this comment.
is this a breaking change? If a user upgrades the SDK do they lose their option?
There was a problem hiding this comment.
Yes. Unfortunately. I aim to include this as the 1.0.0 release to make the breaking change more palatable.
samples/unity-of-bugs/Assets/Scripts/BuildtimeOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
samples/unity-of-bugs/Assets/Scripts/BuildtimeOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
samples/unity-of-bugs/Assets/Scripts/BuildtimeOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
bitsandfoxes
commented
Feb 27, 2023
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs
Outdated
Show resolved
Hide resolved
bruno-garcia
approved these changes
Feb 27, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,8 @@ | |||
| - The option is still available from within the `SentryBuildTimeOptionsConfiguration` | |||
| - Renamed `OptionsConfiguration` to `RuntimeOptionsConfiguration` on the ScriptableSentryOptions ([#1196](https://github.com/getsentry/sentry-unity/pull/1196)) | |||
| - If you make use of programmatic runtime options configuration, you will need to reassign the scriptable object in the configuration tab | |||
| - Renamed `SentryBuiltimeOptionsConfiguration` to `SentryBuilTimeOptionsConfiguration` ([#1187](https://github.com/getsentry/sentry-unity/pull/1187)) | |||
| - If you make use of the programmatic build time configuration, you will need to update your implementation with the base class | |||
There was a problem hiding this comment.
Suggested change
| - If you make use of the programmatic build time configuration, you will need to update your implementation with the base class | |
| ### Note | |
| - If you make use of the programmatic build time configuration, you will need to update your implementation with the base class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to be more upfront and visible about the difference between runtime and build time options.
Trying to emphasis
Build TimevsRuntime.