Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

deps: Remove webpack from peerDep and move info about ver to readme #354

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

kamilogorek
Copy link
Contributor

After discussing it with the team, we decided to revert this change, as the behavior of peerDependenciesMeta is not consistent across npm/yarn versions.

ref: #343
ref: #350

@kamilogorek kamilogorek requested review from a team, Lms24 and AbhiPrasad and removed request for a team February 16, 2022 14:12
@belgattitude
Copy link

belgattitude commented Feb 24, 2022

@kamilogorek

the behavior of peerDependenciesMeta is not consistent

Without peerDependencies + Meta (and optional)... I feel it's gonna be a ping-pong between packages managers issues.

Why not betting on the future ?

And add a note for npm 6/7 (legacy as per their doc) recommending an update to v8 to avoid downloading webpack twice if not needed ?

Would it be more future-proof ? (Maybe with a major version of the sentry webpack plugin ?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants