Fix: Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
changed the title
…/sentry-xamarin into feat/xamarin-privacy-info
…try/sentry-xamarin into feat/xamarin-privacy-info
bruno-garcia
approved these changes
May 1, 2024
|
|
||
| - Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters ([#152](https://github.com/getsentry/sentry-xamarin/pull/152)) | ||
|
|
||
| Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project. |
There was a problem hiding this comment.
Suggested change
| Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project. | |
| Due to new Apple requirements, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the fields required by Sentry, if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file and warn during the build if the required keys are not when building an iOS project. |
| - Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters ([#152](https://github.com/getsentry/sentry-xamarin/pull/152)) | ||
|
|
||
| Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project. | ||
| Below you can find a snippet of the minimum required privacy manifest required by Sentry Xamarin: |
There was a problem hiding this comment.
Suggested change
| Below you can find a snippet of the minimum required privacy manifest required by Sentry Xamarin: | |
| Below you can find a snippet of the minimum privacy manifest required by Sentry Xamarin: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a requirement by Apple
This PR Adds a PrivacyInfo manifest containing all the required parameters by the SDK if the user didn't provide a PrivacyInfo manifest, otherwise, it will warn the user if their PrivacyInfo manifest is missing any required parameter by the SDK.
Other changes:
Close #148