Fix: Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters. #152
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,6 @@ | |
| <!--Automatic upward search ends when first file found. From here we need to manually import parent props/targets | ||
| https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build --> | ||
| <Import Project="..\..\Directory.Build.props" /> | ||
| <Import Project="..\..\Src\Sentry.Xamarin\buildTransitive\Sentry.Xamarin.targets" /> | ||
|
|
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,6 @@ | |
| <!--Automatic upward search ends when first file found. From here we need to manually import parent props/targets | ||
| https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build --> | ||
| <Import Project="..\..\Directory.Build.props" /> | ||
| <Import Project="..\..\Src\Sentry.Xamarin\buildTransitive\Sentry.Xamarin.targets" /> | ||
|
|
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,6 @@ | |
| <!--Automatic upward search ends when first file found. From here we need to manually import parent props/targets | ||
| https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build --> | ||
| <Import Project="..\..\Directory.Build.props" /> | ||
| <Import Project="..\..\Src\Sentry.Xamarin\buildTransitive\Sentry.Xamarin.targets" /> | ||
|
|
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,6 @@ | |
| <!--Automatic upward search ends when first file found. From here we need to manually import parent props/targets | ||
| https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build --> | ||
| <Import Project="..\..\Directory.Build.props" /> | ||
| <Import Project="..\..\Src\Sentry.Xamarin\buildTransitive\Sentry.Xamarin.targets" /> | ||
|
|
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,6 @@ | |
| <!--Automatic upward search ends when first file found. From here we need to manually import parent props/targets | ||
| https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build --> | ||
| <Import Project="..\..\Directory.Build.props" /> | ||
| <Import Project="..\..\Src\Sentry.Xamarin\buildTransitive\Sentry.Xamarin.targets" /> | ||
|
|
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>Some Key Group</key> | ||
| <array> | ||
| <dict> | ||
| <key>test</key> | ||
| <string>test</string> | ||
| </dict> | ||
| <dict> | ||
| <key>test</key> | ||
| <string>test</string> | ||
| </dict> | ||
| </array> | ||
|
|
||
| <key>NSPrivacyAccessedAPITypes</key> | ||
| <array> | ||
| <dict> | ||
| <key>NSPrivacyAccessedAPIType</key> | ||
| <string>NSPrivacyAccessedAPICategoryFileTimestamp</string> | ||
| <key>NSPrivacyAccessedAPITypeReasons</key> | ||
| <array> | ||
| <string>C617.1</string> | ||
| </array> | ||
| </dict> | ||
| <dict> | ||
| <key>NSPrivacyAccessedAPIType</key> | ||
| <string>NSPrivacyAccessedAPICategorySystemBootTime</string> | ||
| <key>NSPrivacyAccessedAPITypeReasons</key> | ||
| <array> | ||
| <string>35F9.1</string> | ||
| </array> | ||
| </dict> | ||
| </array> | ||
|
|
||
| <key>Another Key Group</key> | ||
| <array> | ||
| <dict> | ||
| <key>test</key> | ||
| <string>test</string> | ||
| </dict> | ||
| <dict> | ||
| <key>test</key> | ||
| <string>test</string> | ||
| </dict> | ||
| </array> | ||
| </dict> | ||
| </plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,28 +29,28 @@ | |
| <MtouchDebug>true</MtouchDebug> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|iPhoneSimulator' "> | ||
| <!-- Configure Sentry org and project --> | ||
| <!-- for more information: https://docs.sentry.io/platforms/dotnet/guides/xamarin/configuration/msbuild--> | ||
| <SentryOrg>sentry-sdks</SentryOrg> | ||
| <SentryProject>sentry-xamarin</SentryProject> | ||
| <!-- | ||
| Each of the below features are opt-in. | ||
| Enable the features you wish to use. | ||
| --> | ||
| <!-- Sends symbols to Sentry, enabling symbolication of stack traces. --> | ||
| <SentryUploadSymbols>true</SentryUploadSymbols> | ||
| <!-- Sends sources to Sentry, enabling display of source context. --> | ||
| <SentryUploadSources>true</SentryUploadSources> | ||
| <SentryCLIUploadOptions>--wait</SentryCLIUploadOptions> | ||
| <DebugType>none</DebugType> | ||
| <Optimize>true</Optimize> | ||
| <OutputPath>bin\iPhoneSimulator\Release</OutputPath> | ||
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| <MtouchLink>None</MtouchLink> | ||
| <MtouchArch>x86_64</MtouchArch> | ||
| <!-- Configure Sentry org and project --> | ||
| <!-- for more information: https://docs.sentry.io/platforms/dotnet/guides/xamarin/configuration/msbuild--> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|iPhone' "> | ||
| <DebugSymbols>true</DebugSymbols> | ||
|
|
@@ -76,9 +76,9 @@ | |
| Each of the below features are opt-in. | ||
| Enable the features you wish to use. | ||
| --> | ||
| <!-- Sends symbols to Sentry, enabling symbolication of stack traces. --> | ||
| <SentryUploadSymbols>true</SentryUploadSymbols> | ||
| <!-- Sends sources to Sentry, enabling display of source context. --> | ||
| <SentryUploadSources>true</SentryUploadSources> | ||
| <DebugType>none</DebugType> | ||
| <Optimize>true</Optimize> | ||
|
|
@@ -88,8 +88,8 @@ | |
| <MtouchArch>ARM64</MtouchArch> | ||
| <CodesignKey>iPhone Developer</CodesignKey> | ||
| <CodesignEntitlements>Entitlements.plist</CodesignEntitlements> | ||
| <!-- Configure Sentry org and project --> | ||
| <!-- for more information: https://docs.sentry.io/platforms/dotnet/guides/xamarin/configuration/msbuild--> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(RunConfiguration)' == 'Default' "> | ||
| <AppExtensionDebugBundleId /> | ||
|
|
@@ -101,6 +101,9 @@ | |
| <None Include="Entitlements.plist" /> | ||
| <None Include="Info.plist" /> | ||
| <Compile Include="Properties\AssemblyInfo.cs" /> | ||
| <BundleResource Include="PrivacyInfo.xcprivacy"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </BundleResource> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <InterfaceDefinition Include="Resources\LaunchScreen.storyboard" /> | ||
|
|
@@ -193,4 +196,4 @@ | |
| <UserProperties TriggeredFromHotReload="False" /> | ||
| </VisualStudio> | ||
| </ProjectExtensions> | ||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "solution": { | ||
| "path": "Sentry.Xamarin.sln", | ||
| "projects": [ | ||
| "Src\\Sentry.Xamarin\\Sentry.Xamarin.csproj", | ||
| "Src\\Sentry.Xamarin.Forms\\Sentry.Xamarin.Forms.csproj", | ||
| "Samples\\Sample.Xamarin.Core\\Sample.Xamarin.Core.csproj", | ||
| "Samples\\Sample.Xamarin.UWP\\Sample.Xamarin.UWP.csproj", | ||
| "Samples\\Sample.Xamarin.Mac\\Sample.Xamarin.Mac.csproj", | ||
| "Samples\\Forms\\com.sentry.ovenlibrary\\com.sentry.ovenlibrary.csproj", | ||
| "Samples\\Sample.Xamarin.Droid\\Sample.Xamarin.Droid.csproj", | ||
| "Tests\\Sentry.Xamarin.Forms.Testing\\Sentry.Xamarin.Forms.Testing.csproj", | ||
| "Tests\\Sentry.Xamarin.Tests\\Sentry.Xamarin.Tests.csproj", | ||
| "Tests\\Sentry.Xamarin.Forms.UWP.Tests\\Sentry.Xamarin.Forms.UWP.Tests.csproj" | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "solution": { | ||
| "path": "Sentry.Xamarin.sln", | ||
| "projects": [ | ||
| "Src\\Sentry.Xamarin\\Sentry.Xamarin.csproj", | ||
| "Src\\Sentry.Xamarin.Forms\\Sentry.Xamarin.Forms.csproj", | ||
| "Samples\\Sample.Xamarin.Core\\Sample.Xamarin.Core.csproj", | ||
| "Samples\\Sample.Xamarin.Mac\\Sample.Xamarin.Mac.csproj", | ||
| "Samples\\Forms\\com.sentry.ovenlibrary\\com.sentry.ovenlibrary.csproj", | ||
| "Samples\\Sample.Xamarin.Droid\\Sample.Xamarin.Droid.csproj", | ||
| "Tests\\Sentry.Xamarin.Forms.Testing\\Sentry.Xamarin.Forms.Testing.csproj", | ||
| "Tests\\Sentry.Xamarin.Tests\\Sentry.Xamarin.Tests.csproj" | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| <!--Automatic upward search ends when first file found. From here we need to manually import parent props/targets | ||
| https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build --> | ||
| <Import Project="..\Directory.Build.props" /> | ||
| <Import Project="..\Src\Sentry.Xamarin\buildTransitive\Sentry.Xamarin.targets" /> | ||
|
|
||
| <PropertyGroup> | ||
| <!--Generate xml docs for all projects under 'src'--> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.