Skip to content

Commit

Permalink
stop checking for missing groups when handling processed results
Browse files Browse the repository at this point in the history
  • Loading branch information
lobsterkatie committed May 14, 2024
1 parent 6c80b1e commit 082b775
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions src/sentry/api/endpoints/group_similar_issues_embeddings.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,21 +131,7 @@ def get_formatted_results(
)
}

result = []
for group_id in group_data:
try:
result.append((serialized_groups[group_id], group_data[group_id]))
except KeyError:
# KeyErrors may occur if seer API returns a deleted/merged group, which means it
# will be missing from `serialized_groups`
#
# TODO: This shouldn't be an issue for merged groups once we only use hashes (since
# merging leaves the hashes intact), but it will still be an error for deleted
# groups/hashes.
#
# TODO: Report back to seer that the hash has been deleted.
continue
return result
return [(serialized_groups[group_id], group_data[group_id]) for group_id in group_data]

def get(self, request: Request, group) -> Response:
if not features.has("projects:similarity-embeddings", group.project):
Expand Down

0 comments on commit 082b775

Please sign in to comment.