Change return shape

getsentry · May 9, 2024 · 11277e4 · 11277e4
1 parent 650d74a
commit 11277e4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/src/sentry/api/endpoints/issues/related_issues.py b/src/sentry/api/endpoints/issues/related_issues.py
@@ -6,7 +6,7 @@
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases.group import GroupEndpoint
 from sentry.issues.related import find_related_issues  # To be deprecated
-from sentry.issues.related import same_root_cause_analysis, trace_connected_analysis
+from sentry.issues.related import RELATED_ISSUES_ALGORITHMS
 from sentry.models.group import Group
 from sentry.types.ratelimit import RateLimit, RateLimitCategory
 
@@ -40,8 +40,8 @@ def get(self, request: Request, group: Group) -> Response:
 
         if related_type in RELATED_ISSUES_ALGORITHMS:
             data, meta = RELATED_ISSUES_ALGORITHMS[related_type](group)
-            related_issues = [{"type": related_type, "data": data, "meta": meta}]
+            return Response({"type": related_type, "data": data, "meta": meta})
         else:
             # XXX: We will be deprecating this approach soon
             related_issues = find_related_issues(group)
-        return Response({"data": [related_set for related_set in related_issues]})
+            return Response({"data": [related_set for related_set in related_issues]})
diff --git a/tests/sentry/api/endpoints/issues/test_related_issues.py b/tests/sentry/api/endpoints/issues/test_related_issues.py
@@ -44,9 +44,7 @@ def test_same_root_related_issues(self) -> None:
         # The UI will then make normal calls to get issues-stats
         # For instance, this URL
         # https://us.sentry.io/api/0/organizations/sentry/issues-stats/?groups=4741828952&groups=4489703641&statsPeriod=24h
-        assert response.json() == {
-            "data": [{"type": "same_root_cause", "data": [5], "meta": {}}],
-        }
+        assert response.json() == {"type": "same_root_cause", "data": [5], "meta": {}}
 
     def test_trace_connected_errors(self) -> None:
         error_event, _, another_proj_event = self.load_errors(self.project, uuid4().hex[:16])
@@ -61,15 +59,8 @@ def test_trace_connected_errors(self) -> None:
 
         response = self.get_success_response(qs_params={"type": "trace_connected"})
         assert response.json() == {
-            "data": [
-                {
-                    "type": "trace_connected",
-                    # This is the other issue in the trace that it is not itself
-                    "data": [another_proj_event.group_id],
-                    "meta": {
-                        "event_id": recommended_event.event_id,
-                        "trace_id": error_event.trace_id,
-                    },
-                },
-            ]
+            "type": "trace_connected",
+            # This is the other issue in the trace that it is not itself
+            "data": [another_proj_event.group_id],
+            "meta": {"event_id": recommended_event.event_id, "trace_id": error_event.trace_id},
         }